I ran it locally on NixOS

> ./result/bin/git-of-theseus-analyze --help | head
usage: git-of-theseus-analyze [-h] [--cohortfm COHORTFM] [--interval INTERVAL]
                              [--ignore IGNORE] [--only ONLY]
                              [--outdir OUTDIR] [--branch BRANCH]
                              [--ignore-whitespace] [--all-filetypes]
                              [--quiet] [--procs PROCS] [--opt]
                              repo_dir

Analyze git repo

positional arguments:

You will want to fix-up & reword the commits here via git rebase. Interactively you can:

$ git rebase -i HEAD~2

Will open the $EDITOR. Change

pick 5294d98663 git-of-theseus: init at 961bda0
pick 84bc34afd6 Update package.nix

to

reword 5294d98663 git-of-theseus: init at 961bda0
fixup  84bc34afd6 Update package.nix

Reset the commit message title to reflect the new version @ 0-unstable-2023-02-13 instead of the hash.

$ git rebase --continue

to fixup the initial commit with the new versions.

Then remove the with lib; & rec (if possible). Use git add -p to interactively check over your changes then git commit --amend to amend the original commit. When you are ready to go git push --force-with-lease origin git-of-theseus.

Since these are just fixups based on a review, they should not pollute the Git history.

Also the MS GitHub pull request title here should be updated to reflect the new version as well.

Additionally… you don’t need marketing text in PRs about why, but this is minor.

@toastal thank you for the clear instructions;

I was kind of at first like "ugh" with all the feedback but at least you were very clear on what I had to do -- so it wasn't too bad 🙏

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391587

x86_64-linux

The binaries aren't inside ./result/bin, is this intended? ignore, I was being dumb

can this merge then?

can this merge then?

neither of us can merge this, you will have to ask on the discourse or matrix

I've posted it .... let's see 🙏

issue: version does not match authorship date of commit in rev

The version attribute isn't set to the correct date (should be November 25th, 2023 and not February 13th, 2023)

diff --git a/pkgs/by-name/gi/git-of-theseus/package.nix b/pkgs/by-name/gi/git-of-theseus/package.nix
index 9dd47827bae1..9bc6f303c478 100644
--- a/pkgs/by-name/gi/git-of-theseus/package.nix
+++ b/pkgs/by-name/gi/git-of-theseus/package.nix
@@ -5,7 +5,7 @@
 }:
 python3.pkgs.buildPythonApplication {
   pname = "git-of-theseus";
-  version = "0-unstable-2023-02-13";
+  version = "0-unstable-2023-11-25";
   pyproject = true;

   src = fetchFromGitHub {

@normalcea thanks for catching that -- fixed.