Skip to content

podman-desktop: add podman to PATH #388478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Mar 9, 2025

Otherwise, the basic app functionality - managing containers - requires
a manual configuration of the path to the podman binary.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@booxter
Copy link
Contributor Author

booxter commented Mar 9, 2025

Now - right on startup without any configuration changes:

image

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 9, 2025
@nix-owners nix-owners bot requested a review from panda2134 March 9, 2025 17:45
@booxter
Copy link
Contributor Author

booxter commented Mar 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388478


x86_64-linux

✅ 1 package built:
  • podman-desktop

aarch64-linux

✅ 1 package built:
  • podman-desktop

x86_64-darwin

❌ 1 package failed to build:
  • podman-desktop

aarch64-darwin

✅ 1 package built:
  • podman-desktop

@booxter
Copy link
Contributor Author

booxter commented Mar 9, 2025

The x86_64-darwin failure is due to #373493

@booxter booxter marked this pull request as draft March 9, 2025 17:52
@booxter booxter force-pushed the podman-dep-desktop branch from a2de976 to 4ef892c Compare March 12, 2025 23:25
@booxter booxter marked this pull request as ready for review March 12, 2025 23:25
@booxter
Copy link
Contributor Author

booxter commented Mar 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388478


x86_64-linux

✅ 1 package built:
  • podman-desktop

aarch64-linux

✅ 1 package built:
  • podman-desktop

x86_64-darwin

✅ 1 package built:
  • podman-desktop

aarch64-darwin

✅ 1 package built:
  • podman-desktop

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 13, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@booxter booxter force-pushed the podman-dep-desktop branch from 4ef892c to 32ae631 Compare April 2, 2025 13:43
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@booxter
Copy link
Contributor Author

booxter commented Apr 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388478


aarch64-linux

✅ 1 package built:
  • podman-desktop

x86_64-darwin

✅ 1 package built:
  • podman-desktop

aarch64-darwin

✅ 1 package built:
  • podman-desktop

@booxter
Copy link
Contributor Author

booxter commented Apr 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388478


x86_64-linux

✅ 1 package built:
  • podman-desktop

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@booxter booxter force-pushed the podman-dep-desktop branch from 32ae631 to e448c5d Compare June 10, 2025 02:01
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 10, 2025
@github-actions github-actions bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jun 10, 2025
@booxter booxter marked this pull request as draft June 10, 2025 02:08
@booxter
Copy link
Contributor Author

booxter commented Jun 10, 2025

Need to check if this doesn't require some additional wrapping for PATH to actually work. (Though I wonder why it seemed to have worked the last time I checked - without wrapping.)

@booxter
Copy link
Contributor Author

booxter commented Jun 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388478
Commit: e448c5ddce60cf5a3e8d129ab313cef789375c78


x86_64-linux

✅ 1 package built:
  • podman-desktop

aarch64-linux

✅ 1 package built:
  • podman-desktop

x86_64-darwin

✅ 1 package built:
  • podman-desktop

aarch64-darwin

✅ 1 package built:
  • podman-desktop

@booxter booxter force-pushed the podman-dep-desktop branch from e448c5d to 8599f56 Compare August 10, 2025 22:56
@booxter booxter marked this pull request as ready for review August 10, 2025 23:35
@booxter booxter marked this pull request as draft August 11, 2025 03:04
Otherwise, the basic app functionality - managing containers - requires
a manual configuration of the path to the podman binary.

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
@booxter booxter force-pushed the podman-dep-desktop branch from cce3a74 to 69e852f Compare August 11, 2025 12:15
@booxter booxter changed the title podman-desktop: add podman to buildInputs podman-desktop: add podman to PATH Aug 11, 2025
@booxter booxter marked this pull request as ready for review August 11, 2025 12:16
@booxter
Copy link
Contributor Author

booxter commented Aug 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388478
Commit: 69e852f9d50860cab27866f0ba392c7a2514857e


x86_64-linux

✅ 1 package built:
  • podman-desktop

aarch64-linux

✅ 1 package built:
  • podman-desktop

x86_64-darwin

✅ 1 package built:
  • podman-desktop

aarch64-darwin

✅ 1 package built:
  • podman-desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants