Skip to content

Conversation

zevisert
Copy link
Contributor

@zevisert zevisert commented Mar 6, 2025

Poetry 2.0.1 is the latest version of poetry in nixpkgs-unstable, so
this plugin will likely be widely used as poetry users adopt the new
major version of poetry.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Mar 6, 2025
Poetry 2.0.1 is the latest version of poetry in nixpkgs-unstable, so
this plugin will likely be widely used as poetry users adopt the new
major version of poetry.
@zevisert zevisert force-pushed the add-poetry-plugin-migrate branch from ea0422a to d1cb412 Compare March 6, 2025 19:36
@zevisert
Copy link
Contributor Author

zevisert commented Mar 6, 2025

This is my first contribution, I'm not sure if I did enough testing - but I did read the contribution guide. I force pushed to format the added file with nixfmt.

I did run nix-build -A poetryPlugins.poetry-plugin-migrate from my branch. I suppose I can now run nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" as well

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Mar 6, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 6, 2025
@zevisert
Copy link
Contributor Author

zevisert commented Mar 6, 2025

I ran nixpkgs-review, it originally failed in building poetry, but a few minutes later it was successful (I think because of where nixpkgs:master was). The initial failed log is available in this comment's edit history.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387698


x86_64-linux

✅ 2 packages built:
  • poetryPlugins.poetry-plugin-migrate
  • poetryPlugins.poetry-plugin-migrate.dist

Logs

@nixpkgs-ci nixpkgs-ci bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 4, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 16, 2025
Co-authored-by: qzylinra <qzylinra@users.noreply.github.com>
@zevisert zevisert requested a review from qzylinra August 21, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants