haskellPackages: add script to sweep for unused overrides #384591
Conversation
Well it's a much better approach than my old "let's look at old enough overrides and see if they can be cleaned up". I also just recently realised this could probably be re-purposed for |
b95473c to
66c376b
Compare
|
Re-worked this so it's much more versatile. It's not particularly haskellPackages specific anymore, so maybe it can be placed elsewhere? |
|
I feel it is good here. Why do you use overrideAttrs for doCheck and patches? We normally also control these via overrideCabal within nixpkgs. |
I had overrideCabal at start then noticed that |
| # Utils for sweeping through packages based on some property discoverable at eval time | ||
| # Useful for narrowing down package candidates on which to test some build time property | ||
| # | ||
| # Example 1: finding packages with patches that no longer apply |
There was a problem hiding this comment.
Arguably, here the better approach is to build srcOnly pkg and see whether it fails which is much cheaper.
Used for #384127 , #384431, #397255
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.