rstudio: fix loading of project-specific .Rprofile #382071
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kupac
reviewed
Feb 15, 2025
There was a problem hiding this comment.
I reproduced the bug, then used the fixed version of RStudio.
If local Rprofile was present, it was loaded, otherwise the profile from the user's home was loaded. Just like with the rWrapper. That part looks good.
However, with rstudioServerWrapper, I always got the user .Rprofile, and never the local one. It may be because of the way I start rstudio server:
rserver --server-user kupac --auth-none 1 --server-daemonize 1 --www-port 8787 --server-data-dir ~/.local/rstudio --server-pid-file ~/.local/rstudio/rstudio.pid --database-config-file ~/.config/rstudio/db.conf
what do you mean by "local" one? the project specific one? I'm not sure I understand if the suggested fix in this PR breaks the R server wrapper? |
|
I meant that rserverWrapper didn't read the project specific one on my
setup. Regular rstudioWrapper did. That doesn't mean that server wrapper is
broken. It read the user specific one, which is already an improvement
Bruno Rodrigues ***@***.***> ezt írta (időpont: 2025. febr.
15., Szo 21:14):
… However, with rstudioServerWrapper, I always got the user .Rprofile, and
never the local one.
what do you mean by "local" one? the project specific one? I'm not sure I
understand if the suggested fix in this PR breaks the R server wrapper?
—
Reply to this email directly, view it on GitHub
<#382071 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6X6ONJVVVURDUQRAIBQNT2P6N37AVCNFSM6AAAAABXEZEIUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGA4DKMZZGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: b-rodrigues]*b-rodrigues* left a comment (NixOS/nixpkgs#382071)
<#382071 (comment)>
However, with rstudioServerWrapper, I always got the user .Rprofile, and
never the local one.
what do you mean by "local" one? the project specific one? I'm not sure I
understand if the suggested fix in this PR breaks the R server wrapper?
—
Reply to this email directly, view it on GitHub
<#382071 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6X6ONJVVVURDUQRAIBQNT2P6N37AVCNFSM6AAAAABXEZEIUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGA4DKMZZGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #85840
to reproduce the bug: create a project-specific .Rprofile and start RStudio in that folder: the .Rprofile will be ignored. It seems that is because in the wrapper,
R_PROFILE_USERis hard-coded, and so a project-specific .Rprofile cannot get loaded. UsingR_PROFILEinstead in the wrapper frees upR_PROFILE_USER.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.