Skip to content

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Feb 14, 2025

Things done

eerimoq/asn1tools#191

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage marked this pull request as ready for review February 14, 2025 14:30
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 14, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 14, 2025
@nix-owners nix-owners bot requested a review from hellwolf February 14, 2025 14:54
@GaetanLepage GaetanLepage force-pushed the asn1tools branch 2 times, most recently from 409b2de to c3162f3 Compare February 14, 2025 14:59
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382069


x86_64-linux

❌ 5 packages failed to build:
  • echidna
  • python313Packages.slither-analyzer
  • python313Packages.slither-analyzer.dist
  • python313Packages.web3
  • python313Packages.web3.dist
✅ 36 packages built:
  • asn1editor
  • asn1editor.dist
  • netexec
  • netexec.dist
  • python312Packages.aardwolf
  • python312Packages.aardwolf.dist
  • python312Packages.asn1tools
  • python312Packages.asn1tools.dist
  • python312Packages.eth-account
  • python312Packages.eth-account.dist
  • python312Packages.eth-keyfile
  • python312Packages.eth-keyfile.dist
  • python312Packages.eth-keys
  • python312Packages.eth-keys.dist
  • python312Packages.eth-tester
  • python312Packages.eth-tester.dist
  • python312Packages.py-evm
  • python312Packages.py-evm.dist
  • slither-analyzer (python312Packages.slither-analyzer)
  • slither-analyzer.dist (python312Packages.slither-analyzer.dist)
  • python312Packages.web3
  • python312Packages.web3.dist
  • python313Packages.aardwolf
  • python313Packages.aardwolf.dist
  • python313Packages.asn1tools
  • python313Packages.asn1tools.dist
  • python313Packages.eth-account
  • python313Packages.eth-account.dist
  • python313Packages.eth-keyfile
  • python313Packages.eth-keyfile.dist
  • python313Packages.eth-keys
  • python313Packages.eth-keys.dist
  • python313Packages.eth-tester
  • python313Packages.eth-tester.dist
  • python313Packages.py-evm
  • python313Packages.py-evm.dist

aarch64-linux

❌ 1 package failed to build:
  • echidna
✅ 40 packages built:
  • asn1editor
  • asn1editor.dist
  • netexec
  • netexec.dist
  • python312Packages.aardwolf
  • python312Packages.aardwolf.dist
  • python312Packages.asn1tools
  • python312Packages.asn1tools.dist
  • python312Packages.eth-account
  • python312Packages.eth-account.dist
  • python312Packages.eth-keyfile
  • python312Packages.eth-keyfile.dist
  • python312Packages.eth-keys
  • python312Packages.eth-keys.dist
  • python312Packages.eth-tester
  • python312Packages.eth-tester.dist
  • python312Packages.py-evm
  • python312Packages.py-evm.dist
  • slither-analyzer (python312Packages.slither-analyzer)
  • slither-analyzer.dist (python312Packages.slither-analyzer.dist)
  • python312Packages.web3
  • python312Packages.web3.dist
  • python313Packages.aardwolf
  • python313Packages.aardwolf.dist
  • python313Packages.asn1tools
  • python313Packages.asn1tools.dist
  • python313Packages.eth-account
  • python313Packages.eth-account.dist
  • python313Packages.eth-keyfile
  • python313Packages.eth-keyfile.dist
  • python313Packages.eth-keys
  • python313Packages.eth-keys.dist
  • python313Packages.eth-tester
  • python313Packages.eth-tester.dist
  • python313Packages.py-evm
  • python313Packages.py-evm.dist
  • python313Packages.slither-analyzer
  • python313Packages.slither-analyzer.dist
  • python313Packages.web3
  • python313Packages.web3.dist

x86_64-darwin

⏩ 2 packages marked as broken and skipped:
  • netexec
  • netexec.dist
❌ 9 packages failed to build:
  • echidna
  • python313Packages.eth-tester
  • python313Packages.eth-tester.dist
  • python313Packages.py-evm
  • python313Packages.py-evm.dist
  • python313Packages.slither-analyzer
  • python313Packages.slither-analyzer.dist
  • python313Packages.web3
  • python313Packages.web3.dist
✅ 30 packages built:
  • asn1editor
  • asn1editor.dist
  • python312Packages.aardwolf
  • python312Packages.aardwolf.dist
  • python312Packages.asn1tools
  • python312Packages.asn1tools.dist
  • python312Packages.eth-account
  • python312Packages.eth-account.dist
  • python312Packages.eth-keyfile
  • python312Packages.eth-keyfile.dist
  • python312Packages.eth-keys
  • python312Packages.eth-keys.dist
  • python312Packages.eth-tester
  • python312Packages.eth-tester.dist
  • python312Packages.py-evm
  • python312Packages.py-evm.dist
  • slither-analyzer (python312Packages.slither-analyzer)
  • slither-analyzer.dist (python312Packages.slither-analyzer.dist)
  • python312Packages.web3
  • python312Packages.web3.dist
  • python313Packages.aardwolf
  • python313Packages.aardwolf.dist
  • python313Packages.asn1tools
  • python313Packages.asn1tools.dist
  • python313Packages.eth-account
  • python313Packages.eth-account.dist
  • python313Packages.eth-keyfile
  • python313Packages.eth-keyfile.dist
  • python313Packages.eth-keys
  • python313Packages.eth-keys.dist

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • netexec
  • netexec.dist
❌ 1 package failed to build:
  • echidna
✅ 38 packages built:
  • asn1editor
  • asn1editor.dist
  • python312Packages.aardwolf
  • python312Packages.aardwolf.dist
  • python312Packages.asn1tools
  • python312Packages.asn1tools.dist
  • python312Packages.eth-account
  • python312Packages.eth-account.dist
  • python312Packages.eth-keyfile
  • python312Packages.eth-keyfile.dist
  • python312Packages.eth-keys
  • python312Packages.eth-keys.dist
  • python312Packages.eth-tester
  • python312Packages.eth-tester.dist
  • python312Packages.py-evm
  • python312Packages.py-evm.dist
  • slither-analyzer (python312Packages.slither-analyzer)
  • slither-analyzer.dist (python312Packages.slither-analyzer.dist)
  • python312Packages.web3
  • python312Packages.web3.dist
  • python313Packages.aardwolf
  • python313Packages.aardwolf.dist
  • python313Packages.asn1tools
  • python313Packages.asn1tools.dist
  • python313Packages.eth-account
  • python313Packages.eth-account.dist
  • python313Packages.eth-keyfile
  • python313Packages.eth-keyfile.dist
  • python313Packages.eth-keys
  • python313Packages.eth-keys.dist
  • python313Packages.eth-tester
  • python313Packages.eth-tester.dist
  • python313Packages.py-evm
  • python313Packages.py-evm.dist
  • python313Packages.slither-analyzer
  • python313Packages.slither-analyzer.dist
  • python313Packages.web3
  • python313Packages.web3.dist

@hellwolf
Copy link
Contributor

Fwiw, I have made an update to echidna in the current haskell-updates head. It requires a fix to the hevm.

Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove echidna change; it conflicts with the haskell-updates PR.

@GaetanLepage
Copy link
Contributor Author

remove echidna change; it conflicts with the haskell-updates PR.

Thanks for the pointer. I removed it.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382069


x86_64-linux

❌ 1 package failed to build:
  • echidna
✅ 40 packages built:
  • asn1editor
  • asn1editor.dist
  • netexec
  • netexec.dist
  • python312Packages.aardwolf
  • python312Packages.aardwolf.dist
  • python312Packages.asn1tools
  • python312Packages.asn1tools.dist
  • python312Packages.eth-account
  • python312Packages.eth-account.dist
  • python312Packages.eth-keyfile
  • python312Packages.eth-keyfile.dist
  • python312Packages.eth-keys
  • python312Packages.eth-keys.dist
  • python312Packages.eth-tester
  • python312Packages.eth-tester.dist
  • python312Packages.py-evm
  • python312Packages.py-evm.dist
  • slither-analyzer (python312Packages.slither-analyzer)
  • slither-analyzer.dist (python312Packages.slither-analyzer.dist)
  • python312Packages.web3
  • python312Packages.web3.dist
  • python313Packages.aardwolf
  • python313Packages.aardwolf.dist
  • python313Packages.asn1tools
  • python313Packages.asn1tools.dist
  • python313Packages.eth-account
  • python313Packages.eth-account.dist
  • python313Packages.eth-keyfile
  • python313Packages.eth-keyfile.dist
  • python313Packages.eth-keys
  • python313Packages.eth-keys.dist
  • python313Packages.eth-tester
  • python313Packages.eth-tester.dist
  • python313Packages.py-evm
  • python313Packages.py-evm.dist
  • python313Packages.slither-analyzer
  • python313Packages.slither-analyzer.dist
  • python313Packages.web3
  • python313Packages.web3.dist

aarch64-linux

❌ 1 package failed to build:
  • echidna
✅ 40 packages built:
  • asn1editor
  • asn1editor.dist
  • netexec
  • netexec.dist
  • python312Packages.aardwolf
  • python312Packages.aardwolf.dist
  • python312Packages.asn1tools
  • python312Packages.asn1tools.dist
  • python312Packages.eth-account
  • python312Packages.eth-account.dist
  • python312Packages.eth-keyfile
  • python312Packages.eth-keyfile.dist
  • python312Packages.eth-keys
  • python312Packages.eth-keys.dist
  • python312Packages.eth-tester
  • python312Packages.eth-tester.dist
  • python312Packages.py-evm
  • python312Packages.py-evm.dist
  • slither-analyzer (python312Packages.slither-analyzer)
  • slither-analyzer.dist (python312Packages.slither-analyzer.dist)
  • python312Packages.web3
  • python312Packages.web3.dist
  • python313Packages.aardwolf
  • python313Packages.aardwolf.dist
  • python313Packages.asn1tools
  • python313Packages.asn1tools.dist
  • python313Packages.eth-account
  • python313Packages.eth-account.dist
  • python313Packages.eth-keyfile
  • python313Packages.eth-keyfile.dist
  • python313Packages.eth-keys
  • python313Packages.eth-keys.dist
  • python313Packages.eth-tester
  • python313Packages.eth-tester.dist
  • python313Packages.py-evm
  • python313Packages.py-evm.dist
  • python313Packages.slither-analyzer
  • python313Packages.slither-analyzer.dist
  • python313Packages.web3
  • python313Packages.web3.dist

x86_64-darwin

⏩ 2 packages marked as broken and skipped:
  • netexec
  • netexec.dist
❌ 1 package failed to build:
  • echidna
✅ 38 packages built:
  • asn1editor
  • asn1editor.dist
  • python312Packages.aardwolf
  • python312Packages.aardwolf.dist
  • python312Packages.asn1tools
  • python312Packages.asn1tools.dist
  • python312Packages.eth-account
  • python312Packages.eth-account.dist
  • python312Packages.eth-keyfile
  • python312Packages.eth-keyfile.dist
  • python312Packages.eth-keys
  • python312Packages.eth-keys.dist
  • python312Packages.eth-tester
  • python312Packages.eth-tester.dist
  • python312Packages.py-evm
  • python312Packages.py-evm.dist
  • slither-analyzer (python312Packages.slither-analyzer)
  • slither-analyzer.dist (python312Packages.slither-analyzer.dist)
  • python312Packages.web3
  • python312Packages.web3.dist
  • python313Packages.aardwolf
  • python313Packages.aardwolf.dist
  • python313Packages.asn1tools
  • python313Packages.asn1tools.dist
  • python313Packages.eth-account
  • python313Packages.eth-account.dist
  • python313Packages.eth-keyfile
  • python313Packages.eth-keyfile.dist
  • python313Packages.eth-keys
  • python313Packages.eth-keys.dist
  • python313Packages.eth-tester
  • python313Packages.eth-tester.dist
  • python313Packages.py-evm
  • python313Packages.py-evm.dist
  • python313Packages.slither-analyzer
  • python313Packages.slither-analyzer.dist
  • python313Packages.web3
  • python313Packages.web3.dist

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • netexec
  • netexec.dist
❌ 1 package failed to build:
  • echidna
✅ 38 packages built:
  • asn1editor
  • asn1editor.dist
  • python312Packages.aardwolf
  • python312Packages.aardwolf.dist
  • python312Packages.asn1tools
  • python312Packages.asn1tools.dist
  • python312Packages.eth-account
  • python312Packages.eth-account.dist
  • python312Packages.eth-keyfile
  • python312Packages.eth-keyfile.dist
  • python312Packages.eth-keys
  • python312Packages.eth-keys.dist
  • python312Packages.eth-tester
  • python312Packages.eth-tester.dist
  • python312Packages.py-evm
  • python312Packages.py-evm.dist
  • slither-analyzer (python312Packages.slither-analyzer)
  • slither-analyzer.dist (python312Packages.slither-analyzer.dist)
  • python312Packages.web3
  • python312Packages.web3.dist
  • python313Packages.aardwolf
  • python313Packages.aardwolf.dist
  • python313Packages.asn1tools
  • python313Packages.asn1tools.dist
  • python313Packages.eth-account
  • python313Packages.eth-account.dist
  • python313Packages.eth-keyfile
  • python313Packages.eth-keyfile.dist
  • python313Packages.eth-keys
  • python313Packages.eth-keys.dist
  • python313Packages.eth-tester
  • python313Packages.eth-tester.dist
  • python313Packages.py-evm
  • python313Packages.py-evm.dist
  • python313Packages.slither-analyzer
  • python313Packages.slither-analyzer.dist
  • python313Packages.web3
  • python313Packages.web3.dist

@GaetanLepage GaetanLepage requested a review from NickCao February 14, 2025 23:25
@NickCao NickCao merged commit 67b8f2c into NixOS:master Feb 14, 2025
58 of 59 checks passed
@GaetanLepage GaetanLepage deleted the asn1tools branch February 14, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants