-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
vimPlugins.screenkey-nvim: init at 2.4.2 #382003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ceea5ff
to
262aa3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked by #380691, please don't merge
btw you opened a duplicate PR |
262aa3f
to
bd64a15
Compare
Not quite: this one mistakenly had the commit of the other one, and GitHub prefilled name with the "wrong" commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to upstream, a nerd font is optional. Not sure why we would bundle it in the vim dependencies attribute, either.
@@ -39,6 +39,7 @@ | |||
llvmPackages, | |||
meson, | |||
neovim-unwrapped, | |||
nerd-fonts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nerd-fonts, |
screenkey-nvim = super.screenkey-nvim.overrideAttrs { | ||
dependencies = [ nerd-fonts.droid-sans-mono ]; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screenkey-nvim = super.screenkey-nvim.overrideAttrs { | |
dependencies = [ nerd-fonts.droid-sans-mono ]; | |
}; |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.