Skip to content

Conversation

imadnyc
Copy link
Contributor

@imadnyc imadnyc commented Feb 12, 2025

Added mxw, a neat CLI for managing Glorious mice. I just copied the flake I made a while ago to this -- totally forgot to before.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 12, 2025

src = fetchFromGitHub {
owner = "dkbednarczyk";
repo = pname;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = pname;
repo = "mxw";

src = fetchFromGitHub {
owner = "dkbednarczyk";
repo = pname;
rev = "v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v${version}";
tag = "v${version}";

Comment on lines +29 to +35
meta = with lib; {
description = "";
homepage = "https://github.com/dkbednarczyk/mxw";
license = licenses.mit;
maintainers = with maintainers; [imadnyc];
platforms = platforms.linux;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib; {
description = "";
homepage = "https://github.com/dkbednarczyk/mxw";
license = licenses.mit;
maintainers = with maintainers; [imadnyc];
platforms = platforms.linux;
};
meta = {
description = "CLI for configuring Glorious wireless mice";
homepage = "https://github.com/dkbednarczyk/mxw";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [imadnyc];
platforms = lib.platforms.linux;
};


buildInputs = [cargo systemd];

cargoHash = "sha256-LBrWBrdY6c5U9SIQEPNC5tE3d3bffeuZndFPwxtEetA=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cargoHash = "sha256-LBrWBrdY6c5U9SIQEPNC5tE3d3bffeuZndFPwxtEetA=";
useFetchCargoVendor = true;
cargoHash = "sha256-+7/pJfC9I+ZFhBi+X7/1EIzUVHaScvrElnuFPP+4rLM=";


nativeBuildInputs = [pkg-config];

buildInputs = [cargo systemd];
Copy link
Contributor

@eclairevoyant eclairevoyant Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [cargo systemd];
buildInputs = [ systemd ];

@@ -0,0 +1,36 @@
{
cargo,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cargo,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format with nixfmt-rfc-style

@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants