re-flex_3: inits at version 3.2.11 #381176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethancedwards8
suggested changes
Feb 11, 2025
dbaf7ae to
bcf2ec6
Compare
|
hello @ethancedwards8 , it should be fixed. |
Tert0
reviewed
Feb 12, 2025
|
hello @Tert0 , it should be fixed. |
|
Some suggestions: diff --git a/pkgs/by-name/re/re-flex_3/package.nix b/pkgs/by-name/re/re-flex_3/package.nix
index 8b2a9eb787a9..491fc6ca74e2 100644
--- a/pkgs/by-name/re/re-flex_3/package.nix
+++ b/pkgs/by-name/re/re-flex_3/package.nix
@@ -1,7 +1,9 @@
{
lib,
- fetchFromGitHub,
stdenv,
+ fetchFromGitHub,
+ versionCheckHook,
+ nix-update-script,
}:
stdenv.mkDerivation (finalAttrs: {
@@ -23,9 +25,16 @@ stdenv.mkDerivation (finalAttrs: {
"dev"
];
+ nativeInstallCheckInputs = [ versionCheckHook ];
+ doInstallCheck = true;
+ versionCheckProgram = "${placeholder "bin"}/bin/reflex";
+ versionCheckProgramArg = "--version";
+
+ passthru.updateScript = nix-update-script {};
+
meta = {
description = ''
- High-performance C++ regex library and lexical analyzer generator with Unicode support.
+ High-performance C++ regex library and lexical analyzer generator with Unicode support
'';
longDescription = ''
High-performance C++ regex library and lexical analyzer generator with Unicode support.
@@ -33,11 +42,11 @@ stdenv.mkDerivation (finalAttrs: {
Seamlessly integrates with Bison and other parsers.
'';
homepage = "https://www.genivia.com/reflex.html";
+ changelog = "https://github.com/Genivia/RE-flex?tab=readme-ov-file#changelog";
license = lib.licenses.bsd3;
platforms = lib.platforms.all;
maintainers = with lib.maintainers; [ m1dugh ];
mainProgram = "reflex";
- changelog = "https://github.com/Genivia/RE-flex?tab=readme-ov-file#changelog";
};
}) |
|
hello @Tert0 , If I recall well |
|
Does not seem to be the case: After adding nix-update-script: The overlays does not change the packages: |
|
Ok, seems strange as I already received nixpkgs update bot MR for other packages without this line. |
|
Should be done @Tert0 |
SuperSandro2000
requested changes
Feb 17, 2025
There was a problem hiding this comment.
What is the difference to https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/re/re-flex/package.nix and why do we need an older version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.