-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
python312Packages: dash-bootstrap-templates: init at 1.3.0 #381652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9af456f
to
e8a85f0
Compare
pkgs/development/python-modules/dash-bootstrap-templates/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/dash-bootstrap-templates/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/dash-bootstrap-templates/default.nix
Outdated
Show resolved
Hide resolved
Can you rename the commit and PR title to |
e8a85f0
to
8a5aa87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very last nit
pkgs/development/python-modules/dash-bootstrap-templates/default.nix
Outdated
Show resolved
Hide resolved
This introduces a collection of 52 Plotly figure templates with a Bootstrap theme. Two theme switch components. Stylesheet to apply Bootstrap themes to Plotly Dash components. It is the last 1.x version. The recently released 2.x version is only compatible with Plotly 6, while everything in nixpkgs currently still uses Plotly 5.
8a5aa87
to
b99fa6e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @flokli
This introduces a collection of 52 Plotly figure templates with a Bootstrap theme. Two theme switch components. Stylesheet to apply Bootstrap themes to Plotly Dash components.
It is the last 1.x version. The recently released 2.x version is only compatible with Plotly 6, while everything in nixpkgs currently still uses Plotly 5.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.