Skip to content

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 13, 2025

This introduces a collection of 52 Plotly figure templates with a Bootstrap theme. Two theme switch components. Stylesheet to apply Bootstrap themes to Plotly Dash components.

It is the last 1.x version. The recently released 2.x version is only compatible with Plotly 6, while everything in nixpkgs currently still uses Plotly 5.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@flokli flokli requested a review from fabaff February 13, 2025 05:33
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 13, 2025
@nix-owners nix-owners bot requested a review from natsukium February 13, 2025 05:34
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 13, 2025
@flokli flokli requested a review from Mic92 February 13, 2025 10:03
@flokli flokli force-pushed the dash-bootstrap-templates branch from 9af456f to e8a85f0 Compare February 14, 2025 07:52
@flokli flokli requested a review from GaetanLepage February 14, 2025 07:52
@GaetanLepage
Copy link
Contributor

Can you rename the commit and PR title to python312Packages: dash-bootstrap-templates: init at 1.3.0 please?

@flokli flokli changed the title python.pkgs.dash-bootstrap-templates: init at 1.3.0 python312Packages: dash-bootstrap-templates: init at 1.3.0 Feb 14, 2025
@flokli flokli force-pushed the dash-bootstrap-templates branch from e8a85f0 to 8a5aa87 Compare February 14, 2025 11:29
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very last nit

This introduces a collection of 52 Plotly figure templates with a
Bootstrap theme. Two theme switch components. Stylesheet to apply
Bootstrap themes to Plotly Dash components.

It is the last 1.x version. The recently released 2.x version is only
compatible with Plotly 6, while everything in nixpkgs currently still
uses Plotly 5.
@flokli flokli force-pushed the dash-bootstrap-templates branch from 8a5aa87 to b99fa6e Compare February 14, 2025 14:09
@flokli flokli requested a review from GaetanLepage February 14, 2025 14:10
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381652


x86_64-linux

✅ 4 packages built:
  • python312Packages.dash-bootstrap-templates
  • python312Packages.dash-bootstrap-templates.dist
  • python313Packages.dash-bootstrap-templates
  • python313Packages.dash-bootstrap-templates.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.dash-bootstrap-templates
  • python312Packages.dash-bootstrap-templates.dist
  • python313Packages.dash-bootstrap-templates
  • python313Packages.dash-bootstrap-templates.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.dash-bootstrap-templates
  • python312Packages.dash-bootstrap-templates.dist
  • python313Packages.dash-bootstrap-templates
  • python313Packages.dash-bootstrap-templates.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.dash-bootstrap-templates
  • python312Packages.dash-bootstrap-templates.dist
  • python313Packages.dash-bootstrap-templates
  • python313Packages.dash-bootstrap-templates.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @flokli

@GaetanLepage GaetanLepage merged commit 912eaf1 into NixOS:master Feb 14, 2025
33 of 35 checks passed
@flokli flokli deleted the dash-bootstrap-templates branch March 4, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants