stack-client: init at 5.3.1 #381552
stack-client: init at 5.3.1 #381552
Conversation
There was a problem hiding this comment.
Most important: Make sure to split things correctly into the right files and commits.
You can find more details here: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md
There was a problem hiding this comment.
This file needs to go into pkgs/by-name/st/stack-client/package.nix.
| version = "4.0.5"; | ||
| version = "4.0.6"; | ||
|
|
||
| # when updating, consider bumping elixir version in all-packages.nix | ||
| src = fetchurl { | ||
| url = "https://github.com/rabbitmq/rabbitmq-server/releases/download/v${version}/${pname}-${version}.tar.xz"; | ||
| hash = "sha256-Jn6DvSvegezhq+zjZbUdHR/b6Kgg+QqZwDDrxu21+0g="; | ||
| hash = "sha256-JkXBZtOUJXfccYZyryO/fZUKL3jyKLGq2vhpRENeDo4="; |
There was a problem hiding this comment.
This update needs to go into a separate commit, possibly separate PR - seems unrelated here.
| in | ||
| stdenv.mkDerivation rec { | ||
| pname = "stack-client"; | ||
| version = "latest"; |
There was a problem hiding this comment.
"latest" is not an acceptable version. This needs to be a specific version.
| version = "latest"; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://filehosting-client.transip.nl/packages/stack-source-latest.tar.gz"; |
There was a problem hiding this comment.
Please re-use the version defined above in the URL.
There was a problem hiding this comment.
This should not go into stack-client/, but into pkgs/by-name/kd/kdsingleapplaction/package.nix - and in a separate commit.
|
|
||
| meta = with lib; { | ||
| description = "Single instance application library for Qt6"; | ||
| homepage = "https://github.com/KDAB/KDSingleApplication"; |
There was a problem hiding this comment.
| homepage = "https://github.com/KDAB/KDSingleApplication"; | |
| homepage = "https://github.com/KDAB/KDSingleApplication"; | |
| changelog = "https://github.com/KDAB/KDSingleApplication/releases/v${version}"; |
Having a changelog, ideally pointing right at the correct version, is always nice for update PRs.
| homepage = "https://www.transip.nl/stack/"; | ||
| changelog = "https://www.transip.nl/stack/changelog/"; | ||
| license = licenses.unfree; | ||
| maintainers = with maintainers; [ timoteuszelle ]; |
There was a problem hiding this comment.
You'll have to add yourself to maintainers/maintainer-list.nix, in a separate commit. Also see https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md#how-to-become-a-maintainer.
| libre-graph-api = stdenv.mkDerivation rec { | ||
| pname = "libre-graph-api-cpp-qt-client"; | ||
| version = "1.0.4"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| owner = "owncloud"; | ||
| repo = "libre-graph-api-cpp-qt-client"; | ||
| rev = "v${version}"; | ||
| sha256 = "wbdamPi2XSLWeprrYZtBUDH1A2gdp6/5geFZv+ZqSWk="; | ||
| }; |
There was a problem hiding this comment.
Why is libre-graph-api in a let block and not a standalone package? Any specific reason?
There was a problem hiding this comment.
What is this file about?
|
Should I work on the changes and do a new PR, I won't have time again until somewhere next week? |
No, the changes should be done in this PR. You'll need to "rebase" your branch. Search for "git rebase" for how to do that.
Your time, no worries. Whenever. Some PRs are.. open for years and still returned to and finished :) |
Adds the Stack client, a command-line tool for TransIP's Stack cloud storage service.
Stack is a cloud storage service provided by TransIP (https://www.transip.nl/stack/),
offering secure file storage and synchronization capabilities.
This PR adds the command-line client that allows users to interact with Stack from their terminal.