redpanda-connect: init at 4.47.1 #381463
redpanda-connect: init at 4.47.1 #381463
Conversation
|
This is problematic because that repo contains code under multiple licenses, as explained here. Although they don't go into details, the list of "community" (licensed under Apache-2.0) and "enterprise" (licensed under RCL - Redpanda Community Licence) is available here. I don't think the package in NixOS should contain the enterprise plugins to be honest, because they are not Open Source. I would, however, probably build the module in a way that allows users to turn on those plugins in their builds. I would probably expose a module argument that controls whether those plugins are included (by default false). On the implementation side, a patch removing those plugins from the import section would probably be enough. An alternative is maintaining a flake. I would probably reach out to Redpanda and ask them if they would be willing to host one. |
|
Notes by benthos author about license policies: redpanda-data/connect#2621 (comment) |
|
Seems cmd/redpanda-connect-community/main.go provides open source build with Apache License. |
| mainProgram = "redpanda-connect"; | ||
| homepage = "https://www.redpanda.com/connect"; | ||
| changelog = "https://github.com/redpanda-data/connect/blob/v${version}/CHANGELOG.md"; | ||
| license = lib.licenses.asl20; |
There was a problem hiding this comment.
| license = lib.licenses.asl20; | |
| # quoting https://github.com/redpanda-data/connect/blob/main/licenses/README.md | |
| # Apache-2.0 covers the majority of connectors and functionality. | |
| # RCL (Redpanda Community License) covers enterprise features. | |
| license = lib.licenses.asl20; # sub-package "cmd/redpanda-connect-community" is Apache-2.0-licensed |
So the license is correct if "cmd/redpanda-connect-community" fits in the first category.
Short description: stream processor with many connectors written in Go.
Homepage: https://www.redpanda.com/connect
This package is benthos package clone.
Not sure about license.
@sagikazarmark please review it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.