npmHooks.npmConfigHook: Fix nodeSrc directly use nodejs
#381409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nodeSrc` was set to the source of `nodejs`, from my understanding `node-gyp` use `npm_config_nodedir` (the value of `nodeSrc`) to search for headers file in the `include` directory. But the source of `nodejs` does not provide the said folder causing error like: ``` WARN read config.gypi ENOENT: no such file or directory, open '/nix/store/akcrla03vhw2hhdd6d5fwkbglincjvvy-nodejs-22.13.1-source/include/node/config.gypi' ``` Fix NixOS#372605
FirelightFlagboy
added a commit
to FirelightFlagboy/parsec-cloud-nix
that referenced
this pull request
Feb 12, 2025
- Like for the update script, we need to patch the dependencies `xlsx` to use the CDN. That could be simplified if using `importNpmLock`. - Require patched `npmConfigHook` to set the correct `nodeSrc` dir for `node-gyp` to be able to find `config.gypi` (would be fixed by NixOS/nixpkgs#381409). - Build the `canvas` dependencies require system dependencies (`pixman`, `cairo`, `pango`).
FirelightFlagboy
added a commit
to FirelightFlagboy/parsec-cloud-nix
that referenced
this pull request
Feb 17, 2025
- Like for the update script, we need to patch the dependencies `xlsx` to use the CDN. That could be simplified if using `importNpmLock`. - Require patched `npmConfigHook` to set the correct `nodeSrc` dir for `node-gyp` to be able to find `config.gypi` (would be fixed by NixOS/nixpkgs#381409). - Build the `canvas` dependencies require system dependencies (`pixman`, `cairo`, `pango`).
FirelightFlagboy
added a commit
to FirelightFlagboy/parsec-cloud-nix
that referenced
this pull request
Feb 18, 2025
- Like for the update script, we need to patch the dependencies `xlsx` to use the CDN. That could be simplified if using `importNpmLock`. - Require patched `npmConfigHook` to set the correct `nodeSrc` dir for `node-gyp` to be able to find `config.gypi` (would be fixed by NixOS/nixpkgs#381409). - Build the `canvas` dependencies require system dependencies (`pixman`, `cairo`, `pango`).
FirelightFlagboy
added a commit
to FirelightFlagboy/parsec-cloud-nix
that referenced
this pull request
Feb 27, 2025
* feat(update.sh): Update sed line number with formated flake * fix(update.sh): For version `>=3.3` it require applying patches For now we need to patch the `xlsx` dependencies that is vendored to use the cdn instead to work with `prefetch-npm-deps`. This could be solved using `importNpmDeps` * fix(client): native build require heavy patching - Like for the update script, we need to patch the dependencies `xlsx` to use the CDN. That could be simplified if using `importNpmLock`. - Require patched `npmConfigHook` to set the correct `nodeSrc` dir for `node-gyp` to be able to find `config.gypi` (would be fixed by NixOS/nixpkgs#381409). - Build the `canvas` dependencies require system dependencies (`pixman`, `cairo`, `pango`). * refactor: Use `callPackage`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodeSrcwas set to the source ofnodejs, from my understandingnode-gypusenpm_config_nodedir(the value ofnodeSrc) to search for headers file in theincludedirectory.But the source of
nodejsdoes not provide the said folder causing error like:Fix #372605
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.