You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
Since llvm/llvm-project#125922 was closed, let's drop the patch. Also unbreaks llvmPackages_git.compiler-rt from eval.
If you're referring to the eval breakage; I think it's because the patch applies to both _20 and _git, but the patch only exists in the _20 directory, so _git is broken.
The patch remains necessary for nixpkgs to build useLLVM packages on aarch64, for now. I closed llvm/llvm-project#125922 because it may not be the right approach for LLVM, or it needs more momentum behind it. The question we'd need to answer is if the nixpkgs side really needs a libc-free compiler-rt or if we can instead provide the libc headers to the compiler-rt builtins build.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Since llvm/llvm-project#125922 was closed, let's drop the patch. Also unbreaks
llvmPackages_git.compiler-rtfrom eval.CC @peterwaller-arm
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.