Skip to content

python-modules.appengine-python-standard: init #380457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ollyfg
Copy link

@ollyfg ollyfg commented Feb 8, 2025

This PR adds a new python package: appengine-python-standard.

This is used when writing services that use Google's managed App Engine environment.
More details on the Github repository for this package: https://github.com/GoogleCloudPlatform/appengine-python-standard

I am adding this because it is used in one of my personal projects, so I'm happy to maintain it.

This PR is a draft while I figure out a few things (and review some other PRs).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Hello everyone!

I'm relatively new to Nix, and am using NixOS for my personal computer.
I'm happy to maintain packages that are used by my personal projects, though I won't be doing anything too complex or daring until I find my feet properly.

I hope this is the start of a good new chapter!
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Feb 8, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Feb 8, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 8, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/building-a-python-package-before-contributing/59999/1

@ollyfg
Copy link
Author

ollyfg commented Feb 9, 2025

I see, thank you very much! I knew I was missing something, but wasn't sure what/where to put it.

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Feb 9, 2025

In addition to the requested changes above, the 2nd commit and the overall PR should be titled python312Packages.appengine-python-standard: init at 1.1.9, otherwise it won't get built by CI

@ollyfg
Copy link
Author

ollyfg commented Feb 10, 2025

Thank you!

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 10, 2025
@ollyfg
Copy link
Author

ollyfg commented Feb 10, 2025

Thank you both very much for your help so far - it's been really useful!

Would one of you be able to help me with a problem I'm hitting when building this locally (nix-build -A python312Packages.appengine-python-standard).

This package depends on urllib3. It requires a version between 1.26.2 and 2.
Unfortunately the current version of urllib3 (both in pypi and so the one packaged in nix) is 2.3.0.

I know how to make a new version of urllib3 pinned to the oldest 1.x version, but I imagine there are conventions around where/how to do this:

  • Do I put it in the urlllib3 package as some other kind of export?
  • Do I build it inside my package (so put a second buildPythonPackage call in my package)?

Would you mind pointing me in the right direction? ideally another package with a similar issue, so I can see how it's supposed to be done.

This commit adds a new python package: appengine-python-standard.

This is used when writing services that use Google's managed App Engine environment.
More details on the Github repository for this package: https://github.com/GoogleCloudPlatform/appengine-python-standard
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants