nixos/picom: update configuration format #379151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding conditions for `()` and a few code changes
NotAShelf
suggested changes
Feb 3, 2025
adding comments again because I didn't realize I removed them
|
Please also change the commit. It could be squashed, but in an ideal case you follow the contribution rules. If we are being really nitpicky, a good and descriptive commit message would not go amiss. Additionally, I am not exactly sure if this is enforced but the title and commit should be all lowercase: - NixOS/picom: Update configuration format
+ nixos/picom: update configuration format |
thank you for your input, resolved all the issues; please check when you can and let me know |
NotAShelf
approved these changes
Feb 3, 2025
2hexed
added a commit
to 2hexed/nixpkgs
that referenced
this pull request
Mar 20, 2025
re-submitting NixOS#379151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to configure picom's options via
(), which is required when working with "rules" or "animations"; This PR resolves that issue along with a few code optimizationsFeel free to propose edits I'll be sure to read them and make changes accordingly; Thanks!
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.