Skip to content

Conversation

aqxa1
Copy link

@aqxa1 aqxa1 commented Feb 3, 2025

See: Unrud/RadicaleInfCloud#27

Fixes compatibility of radicale-infcloud with radicale >=3.2 using third party patch. Just adds back the missing hyperlink to InfCloud from the radicale interface.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 3, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Feb 3, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 3, 2025
@nix-owners nix-owners bot requested a review from erictapen February 3, 2025 03:52
@@ -18,6 +19,14 @@ buildPythonPackage {
hash = "sha256-xzBWIx2OOkCtBjlff1Z0VqgMhxWtgiOKutXUadT3tIo=";
};

patches = [
# Fix for: https://github.com/Unrud/RadicaleInfCloud/issues/26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but could you rather link the corresponding PR? Unrud/RadicaleInfCloud#27

@erictapen
Copy link
Member

Thanks. Now please squash into one commit and I'll merge.

@aqxa1 aqxa1 force-pushed the radicale-infcloud-fix branch from 26db409 to 0740efb Compare February 6, 2025 03:21
@aqxa1
Copy link
Author

aqxa1 commented Feb 6, 2025

Done. It's been a while, so hopefully I pushed correctly.

@erictapen
Copy link
Member

It's perfect, thank you

@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants