vimPlugins: disallow packaging plugins that are already in luaPackages #376370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
khaneliman
requested changes
Jan 24, 2025
| "nui-nvim" | ||
| "nvim-cmp" | ||
| "nvim-nio" | ||
| "orgmode" |
There was a problem hiding this comment.
We specifically left this as a neovim package because the Lua package didn't work. We need to test these instead of just assuming the functionality works because of differences between the sets in how they work.
There was a problem hiding this comment.
Hmm it doesn't work on unstable for me either, though with different error
Unsure what to do with this one
We need to test these instead of just assuming the functionality works because of differences between the sets in how they work
Assuming that latest commit works as well as stable release is also not correct
There was a problem hiding this comment.
Hmm it doesn't work on unstable for me either, though with different error
Unsure what to do with this one
I dont use orgmode so I asked someone to test and @mrcjkb tested the change. I forgot the change came from a PR about it possibly not working already on master... :S
There was a problem hiding this comment.
I tried adding orgmode to my config and it worked on this PR and on master
|
Also curious how many of the checks ran on these because I still have to figure out why sometimes the checkHook doesn't run on luaPackages built as neovim plugins |
53bf50f to
743648a
Compare
|
The other plugins that I do use I just tested and seem like they are functioning, fine. I guess it just depends on what we want to do with orgmode.. |
13 tasks
|
Alright, now this one :p |
teto
approved these changes
Feb 6, 2025
743648a to
f05509a
Compare
f05509a to
b1ffdff
Compare
|
Rebased, can we merge this now? |
|
GaetanLepage
approved these changes
Feb 7, 2025
|
Also wait please for my next nixpkgs-review with |
khaneliman
approved these changes
Feb 7, 2025
|
No new regressions https://gist.github.com/PerchunPak/d07f45f87dfb53224c580d2f2cb192ba |
This was referenced Feb 12, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also a preparation for the updater script update.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.