Skip to content

vimPlugins: move non-github plugins to separate files #376366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

vimPlugins: move non-github plugins to separate files #376366

merged 1 commit into from
Jan 28, 2025

Conversation

PerchunPak
Copy link
Member

@PerchunPak PerchunPak commented Jan 24, 2025 •
edited
Loading

The future version of updater won't support anything except GitHub because it creates a lot of maintenance, and it is just easier to handle such plugins independently.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

CC @NixOS/neovim

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: vim Advanced text editor label Jan 24, 2025
@GaetanLepage
Copy link
Contributor

The future version won't support anything except GitHub because it creates a lot of maintenance and it is just easier to handle such plugins independently.

The future version of updater won't support anything except GitHub because it creates a lot of maintenance, and it is just easier to handle such plugins independently.

I think you forgot to delete one of the two ;)

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 24, 2025
@PerchunPak
Copy link
Member Author

lsp-progress-nvim is added back in #376370

@PerchunPak
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376366

x86_64-linux

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

aarch64-linux

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

x86_64-darwin

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

aarch64-darwin

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

khaneliman
khaneliman reviewed Jan 24, 2025
View reviewed changes
khaneliman
khaneliman reviewed Jan 24, 2025
View reviewed changes
khaneliman
khaneliman approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376366

x86_64-linux

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

aarch64-linux

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

x86_64-darwin

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

aarch64-darwin

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 25, 2025
@khaneliman
Copy link
Contributor

Sorry, forgot about this... can you resolve conflicts

@PerchunPak
vimPlugins: move non-github plugins to separate files
90ba4a9 
The future version won't support anything except GitHub because it
creates a lot of maintenance and it is just easier to handle such
plugins independently.
PerchunPak
PerchunPak commented Jan 28, 2025
View reviewed changes
pkgs/applications/editors/vim/plugins/generated.nix
@@ -1,5 +1,5 @@
# GENERATED by ./pkgs/applications/editors/vim/plugins/update.py. Do not edit!
{ lib, buildVimPlugin, buildNeovimPlugin, fetchFromGitHub, fetchgit }:
{ lib, buildVimPlugin, buildNeovimPlugin, fetchFromGitHub }:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and the only change is this, to cause an eval failure if someone tries to add non-github plugin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, accidentally gave you a sneak-pick for the new generated.json

https://github.com/NixOS/nixpkgs/blob/90df3069476a28e3866ef8163c36d83184a88367/pkgs/applications/editors/vim/plugins/generated.json

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376366

x86_64-linux

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

aarch64-linux

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

x86_64-darwin

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

aarch64-darwin

✅ 9 packages built:
  • vimPlugins.clangd_extensions-nvim
  • vimPlugins.cmp-async-path
  • vimPlugins.gitlab-vim
  • vimPlugins.hare-vim
  • vimPlugins.lsp_lines-nvim
  • vimPlugins.nvim-julia-autotest
  • vimPlugins.rainbow-delimiters-nvim
  • vimPlugins.vim-stationeers-ic10-syntax
  • vimPluginsUpdater

@khaneliman khaneliman merged commit 00e2be9 into NixOS:master Jan 28, 2025
25 of 27 checks passed
@PerchunPak PerchunPak deleted the move-non-github-pls branch January 28, 2025 20:53
@PerchunPak PerchunPak mentioned this pull request Feb 2, 2025
Merged
13 tasks
@khaneliman khaneliman mentioned this pull request Aug 6, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaneliman khaneliman khaneliman approved these changes

@mrcjkb mrcjkb Awaiting requested review from mrcjkb

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs

@figsoda figsoda Awaiting requested review from figsoda

@manveru manveru Awaiting requested review from manveru

@GaetanLepage GaetanLepage Awaiting requested review from GaetanLepage

Assignees
No one assigned
Labels
6.topic: vim Advanced text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PerchunPak @GaetanLepage @khaneliman @wegank