Skip to content

moondeck-buddy: init at 1.6.3 #375287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

moondeck-buddy: init at 1.6.3 #375287

wants to merge 1 commit into from

Conversation

redxtech
Copy link
Contributor

MoonDeck Buddy

A server-side part of the MoonDeck plugin for the SteamDeck.

MoonDeck Buddy is a companion app for the MoonDeck plugin for decky on the steam deck. It enables you to launch steam games for a remote session using moonlight/sunlight from the steam deck.

Homepage/Repo: https://github.com/FrogTheFrog/moondeck-buddy
License: LGPL-3.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 20, 2025
@redxtech redxtech force-pushed the init-moondeck-buddy branch from 364e170 to 7ca35fb Compare January 20, 2025 09:41
@keenanweaver
Copy link
Member

PR will close #354802.

Building & working for me.

The derivation in that thread has a postPatch in there. Should that be included in this PR?

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375287

x86_64-linux

✅ 1 package built:
  • moondeck-buddy

@redxtech redxtech force-pushed the init-moondeck-buddy branch from 7ca35fb to 425e6c3 Compare January 24, 2025 07:05
@redxtech redxtech mentioned this pull request Jan 24, 2025
Open
@github-actions github-actions bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Jan 24, 2025
@redxtech redxtech force-pushed the init-moondeck-buddy branch from 425e6c3 to e204e88 Compare January 24, 2025 22:30
ethancedwards8
ethancedwards8 suggested changes Feb 1, 2025
View reviewed changes
@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375287

@redxtech redxtech force-pushed the init-moondeck-buddy branch from e204e88 to 35ed3b9 Compare February 11, 2025 00:16
@keenanweaver keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 11, 2025
@redxtech redxtech force-pushed the init-moondeck-buddy branch from 35ed3b9 to daa6992 Compare February 11, 2025 01:13
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 11, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/problem-building-a-package-using-cmake-depending-on-proc-procps-in-flake/57201/7

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375287

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Feb 22, 2025
@SkyLeite
Copy link

SkyLeite commented Feb 25, 2025 •
edited
Loading

This is failing for me with a hash mismatch.

error: hash mismatch in fixed-output derivation '/nix/store/bqq7p6vmjagmsc5frx4p5wgiv25ifchz-source.drv':
         specified: sha256-CcORcojz3jh1UZpq5qjDv+YktXC+F8t+r7E1SFyFkmw=
            got:    sha256-OMgcxRpXhZNfvixq4PTeKfddCTzaqMGaaxaNFOWEnTw=

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375287

x86_64-linux

❌ 1 package failed to build:
  • moondeck-buddy

@ccalhoun1999
Copy link

Same error for me.

@ccalhoun1999
Copy link

ccalhoun1999 commented Feb 28, 2025 •
edited
Loading

Has anyone been able to actually use this? It just says the host is unreachable whenever I try to connect. I've opened up the port that pops up in the log when running moondeckbuddy.
The port that pops up in log is the wrong one. You can use one opened when you install sunshine. The port for me was 47989, but I did need to add it manually.

@keenanweaver
Copy link
Member

The package was updated upstream with the same version, so it needs to be updated to sha256-OMgcxRpXhZNfvixq4PTeKfddCTzaqMGaaxaNFOWEnTw=

This is how I have this all working in my setup.

I do have to remove the pairing and readd it to Moonlight every so often, but otherwise seems to work normally.

keenanweaver
keenanweaver suggested changes May 12, 2025
View reviewed changes
Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to latest and fixed the substitute as the original file doesn't exist anymore.

Tested re-adding, streaming, etc., and all seems well.

pkgs/by-name/mo/moondeck-buddy/package.nix
in
stdenv.mkDerivation (finalAttrs: {
pname = "moondeck-buddy";
version = "1.6.3";
Copy link
Member

@keenanweaver keenanweaver May 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "1.6.3";
version = "1.9.0";

pkgs/by-name/mo/moondeck-buddy/package.nix
repo = "moondeck-buddy";
tag = "v${finalAttrs.version}";
fetchSubmodules = true;
hash = "sha256-CcORcojz3jh1UZpq5qjDv+YktXC+F8t+r7E1SFyFkmw=";
Copy link
Member

@keenanweaver keenanweaver May 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hash = "sha256-CcORcojz3jh1UZpq5qjDv+YktXC+F8t+r7E1SFyFkmw=";
hash = "sha256-Po+cjleec3tDz5IXWYUhWg83Bfp7pJ/IRTiV4HV79zA=";

pkgs/by-name/mo/moondeck-buddy/package.nix
Comment on lines +49 to +52
postPatch = lib.optionalString useNixSteam ''
substituteInPlace src/lib/os/linux/steamregistryobserver.cpp \
--replace-fail /usr/bin/steam ${lib.getExe steam};
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
postPatch = lib.optionalString useNixSteam ''
substituteInPlace src/lib/os/linux/steamregistryobserver.cpp \
--replace-fail /usr/bin/steam ${lib.getExe steam};
'';
postPatch = lib.optionalString useNixSteam ''
substituteInPlace src/lib/shared/appmetadata.cpp \
--replace-fail /usr/bin/steam ${lib.getExe steam};
'';

keenanweaver
keenanweaver reviewed Aug 17, 2025
View reviewed changes
Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to latest release/hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@keenanweaver keenanweaver keenanweaver requested changes

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@redxtech @keenanweaver @ethancedwards8 @nixos-discourse @SkyLeite @ccalhoun1999 @wegank