-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
mrustc: 0.10.1 -> 0.11.2 #375039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mrustc: 0.10.1 -> 0.11.2 #375039
Conversation
|
I would like to merge this, as it reduces a potential fully-from-source bootstrap chain for rust from 1.54+ to 1.74+, removing about 20 versions from the chain, and potential hours of CI time if we get a full-source bootstrap. |
Have you checked that mrustc-bootstrap still works? I think I marked this as a draft because that is likely to break, but it's a long build so I haven't tried it myself. |
This does seem to break the bootstrap. not sure what to do about that, if you want to investigate it. If not, fair enough. |
Yeah let me look into that once I have some time. I think the bootstrap derivation is the real important part of what's here so I want to make sure it keeps working. I was able to update the no-download patch pretty easily, hopefully the bootstrap itself will go smoothly. |
* Add perl, needed to run openssl's Configure script * Remove no-longer-used openssl from input derivation
Cool, the bootstrap is working now. Needed to update the dont-download patch, and the bootstrap was changed upstream to use vendored openssl, which is actually convenient here as we don't need to figure out which hyper-specific old openssl version it needs to build against. Just needed to add perl so that it could run openssl's Configure script. Still bootstrapping with 1.54, which I think is OK for now because it's more of a regression test for the bootstrapping proof-of-concept. Can always look into bumping it up to 1.74+ if/when we want to start using this in-tree for our rustc bootstrapping chain. |
* mrustc.bootstrap: update dont-download-rustc.patch * mrustc.bootstrap: fix vendored openssl build
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/mrustc/versions.
meta.description for mrustc is: Mutabah's Rust Compiler
meta.homepage for mrustc is: https://github.com/thepowersgang/mrustc
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from the cache:
(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review
resultGenerated using
nixpkgs-review
.Command:
nixpkgs-review
x86_64-linux
✅ 2 packages built:
Maintainer pings
cc @progval @r-burns for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*
, you can comment@NixOS/nixpkgs-merge-bot merge
to automatically merge this update using thenixpkgs-merge-bot
.Add a 👍 reaction to pull requests you find important.