Skip to content

Conversation

rc-zb
Copy link
Contributor

@rc-zb rc-zb commented Jan 23, 2025

This is originally part of #373716. However, the latter is currently stuck in abstruse build failures. So these commits are extracted out for review first.

  1. Separate again the recipes for racket and racket-minimal for maintainability.
  2. Add sqlite.out to the dependency list of racket-minimal to fix a documentation build failure.
  3. Restore the patch added by racket: patching out runtime variant detection, fix #114993 #118490 to fix racket: can't find Racket executable for variant cs #377763.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rc-zb rc-zb mentioned this pull request Jan 23, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 23, 2025
@rc-zb rc-zb marked this pull request as ready for review January 23, 2025 03:41
@rc-zb rc-zb changed the title racket: separate recipes, fix documentation build failure for lack of SQLite of minimal distribution racket: separate recipes, fix bugs Jan 30, 2025
@fin444
Copy link
Contributor

fin444 commented Jan 30, 2025

Tests seem to be failing due to 504 errors on Github's end

@GaetanLepage
Copy link
Contributor

Can you rebase and force-push @rc-zb ?

@rc-zb
Copy link
Contributor Author

rc-zb commented Feb 4, 2025

OK. @GaetanLepage

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375992


x86_64-linux

✅ 3 packages built:
  • racket
  • racket-minimal
  • vscode-extensions.eugleo.magic-racket

aarch64-linux

✅ 3 packages built:
  • racket
  • racket-minimal
  • vscode-extensions.eugleo.magic-racket

x86_64-darwin


aarch64-darwin

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 4, 2025
@rc-zb rc-zb mentioned this pull request Feb 7, 2025
13 tasks
Copy link
Contributor

@fin444 fin444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested on x86_64-linux, LGTM

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 10, 2025
@FliegendeWurst FliegendeWurst merged commit be67f66 into NixOS:master Feb 11, 2025
28 checks passed
@rc-zb rc-zb deleted the racket-fix branch February 12, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

racket: can't find Racket executable for variant cs
5 participants