Skip to content

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Jan 21, 2025

Hi,

This add DART: Dynamic Animation and Robotics Toolkit (https://dartsim.github.io/)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 21, 2025
@nix-owners nix-owners bot requested a review from natsukium January 21, 2025 16:56
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 21, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 2, 2025
@nim65s nim65s force-pushed the dart branch 3 times, most recently from 9e3e2bd to bcb6b61 Compare March 30, 2025 15:59
@nim65s
Copy link
Contributor Author

nim65s commented Mar 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375590


x86_64-linux

✅ 3 packages built:
  • dartsim
  • python312Packages.dartsim
  • python313Packages.dartsim

aarch64-darwin

✅ 3 packages built:
  • dartsim
  • python312Packages.dartsim
  • python313Packages.dartsim

Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375590


x86_64-linux

✅ 3 packages built:
  • dartsim
  • python312Packages.dartsim
  • python313Packages.dartsim

aarch64-linux

✅ 3 packages built:
  • dartsim
  • python312Packages.dartsim
  • python313Packages.dartsim

x86_64-darwin

✅ 3 packages built:
  • dartsim
  • python312Packages.dartsim
  • python313Packages.dartsim

aarch64-darwin

✅ 3 packages built:
  • dartsim
  • python312Packages.dartsim
  • python313Packages.dartsim

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaetanLepage GaetanLepage merged commit f40d957 into NixOS:master Apr 9, 2025
27 of 29 checks passed
@nim65s nim65s deleted the dart branch May 9, 2025 08:53
@nim65s nim65s mentioned this pull request Aug 10, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants