-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
nixos/authentik: init #375509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
nixos/authentik: init #375509
Conversation
a633cda to
ec4bc0e
Compare
|
Hi @getchoo sorry, I just added you silently as a reviewer because GitHub suggested you. Would you be available for a review? Respectively could you recommend someone who would be a good fit for a review? Thanks! |
ec4bc0e to
196dfec
Compare
|
Today I figured out how to run the test and actually the test was not working. I've now changed the test itself and the locally created database to be connected to via a Unix socket rather than a port and now the test is running. |
196dfec to
000028f
Compare
000028f to
eeaf6f2
Compare
|
@drupol Thanks for reviewing again and sorry for doing the wrong change back to Do you maybe have someone in mind that could do a second review + merge? |
Hi,
I've been working quite a while on this authentik service module and now want to share it with the NixOS community. I'm aware of https://github.com/nix-community/authentik-nix/ but I've done a couple of things a bit different.
Things that imho are solved better compared to authentik-nix:
Things that are missing compared to authentik-nix:
In general I would say this module is more implemented the NixOS-way. But I also know that the 8 contributors of authentik-nix have invested a lot of brainpower and might have more experience with authentik and Linux / NixOS in general. And I may also have oversimplified things.
That being said, I'm looking forward for your reviews! Thanks!
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.