nixos/nix: add option to preface remote machines with a comment #374360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently ran into an issue where I wasn't able to use the DNS hostname of a
machine inside the /etc/nix/machines file. Nothing to do with NixOS or Nix
itself, just a weird networking setup I was in. This meant I had to use the
plain IPv4 and IPv6 addresses of those machines in these files.
I still like to have some reference to what these machines are, so I've always
put a comment above the remote machine line with the DNS name of the machine,
and then use the hostName option for the IP address.
This adds the nix.buildMachines.*.comment option. Allows us to do the following.
{
nix.buildMachines = [
{
protocol = "ssh-ng";
sshUser = "nixbld";
hostName = "192.168.0.222";
comment = "Some very powerful machine in Belgium";
}
];
}
Which would result in the following /etc/nix/machines entry.
# Some very powerful machine in Belgium
ssh-ng://nixbld@192.168.0.222 - - 1 1 - - -
853d8db to
9ca8622
Compare
Shawn8901
reviewed
Jan 16, 2025
7d74966 to
f5b3048
Compare
I had a comparable problem that I solved by defining a host in the SSH client configuration: Also works if the SSH service listens on a non‐standard port. |
|
Closing since I've been using the fix suggested above, and have been satisfied with is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into an issue where I wasn't able to use the DNS hostname of a machine inside the /etc/nix/machines file. Nothing to do with NixOS or Nix itself, just a weird networking setup I was in. This meant I had to use the plain IPv4 and IPv6 addresses of those machines in these files.
I still like to have some reference to what these machines are, so I've always put a comment above the remote machine line with the DNS name of the machine, and then use the hostName option for the IP address.
This adds the nix.buildMachines.*.comment option. Allows us to do the following.
Which would result in the following /etc/nix/machines entry.
I also went ahead and formatted this module with
nix run nixpkgs#nixfmt, not sure if that's allowed.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.