Skip to content

Conversation

Moraxyc
Copy link
Member

@Moraxyc Moraxyc commented Jan 15, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 15, 2025
@Moraxyc

This comment was marked as outdated.

@L-Trump L-Trump added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jan 17, 2025
@Moraxyc Moraxyc force-pushed the update-nezha-themes branch from 29eb88a to 7b73338 Compare January 22, 2025 05:07
@Moraxyc
Copy link
Member Author

Moraxyc commented Jan 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374097


x86_64-linux

✅ 2 packages built:
  • nezha-theme-admin
  • nezha-theme-user

aarch64-linux

✅ 2 packages built:
  • nezha-theme-admin
  • nezha-theme-user

x86_64-darwin

✅ 2 packages built:
  • nezha-theme-admin
  • nezha-theme-user

aarch64-darwin

✅ 2 packages built:
  • nezha-theme-admin
  • nezha-theme-user

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage GaetanLepage merged commit 0488e92 into NixOS:master Jan 22, 2025
25 of 27 checks passed
@Moraxyc Moraxyc deleted the update-nezha-themes branch January 22, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants