probe-rs-udev-rules: init at 0-unstable-2024-02-25 & picoprobe-udev-rules: remove/rename #373008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier 'reivilibre <git.contact@librepush.net>
Signed-off-by: Olivier 'reivilibre <git.contact@librepush.net>
Signed-off-by: Olivier 'reivilibre <git.contact@librepush.net>
|
Hi, I'm glad to hear that this package is being updated or improved, it was just a quick hack from my side, so I'm really glad it got an overhaul. I sadly haven't had much time for updating my packages and maintaining them, so I'm glad there's now a nice alternative. |
qzylinra
reviewed
Aug 16, 2025
| runHook postInstall | ||
| ''; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| meta = { |
with lib; is outdate
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/probe-rs/webpage/raw/c8dbcf00cef641117578aa3eccd26541b0e259f6/src/static/files/69-probe-rs.rules"; | ||
| sha256 = "sha256-SdwESnOuvOKMsTvxyA5c4UwtcS3kU33SlNttepMm7HY="; |
There was a problem hiding this comment.
Suggested change
| sha256 = "sha256-SdwESnOuvOKMsTvxyA5c4UwtcS3kU33SlNttepMm7HY="; | |
| hash = "sha256-SdwESnOuvOKMsTvxyA5c4UwtcS3kU33SlNttepMm7HY="; |
use hash for sri hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I add a package with the
udevrules forprobe-rs, a tool for controlling USB debug probes from various vendors. Website: https://probe.rsSince an old version of these rules was actually already present in nixpkgs (unbeknownst to me when I started) under the name
picoprobe-udev-rules, I decided to remove that and add a 'rename' alias so that any current users of the Pico are not broken.I'm not ultimately sure if this was the right thing to do, but it seemed better than having two packages with the same contents, or one with the wrong name.
cc. @MGlolenstine I don't know if you have thoughts on this or would want to be a maintainer of the package still? Since now it is no longer just aimed as specific to the Pico, it might be broader than what you intended to support as a package maintainer.
I am happy to do either way.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.