snow-plow: init at 0.1.0 #368273
Open
snow-plow: init at 0.1.0 #368273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b10e87 to
836ef44
Compare
|
@NixOS/nix-formatting nixfmt-check fails, yet I have run |
|
There's no need to manually get the right nixfmt version, the CI failure mentions:
|
836ef44 to
41ba76c
Compare
I thought I did that, but apparently doing it again did something. And it works! Thanks. |
Moraxyc
reviewed
Feb 18, 2025
| src = fetchFromGitHub { | ||
| owner = "JeanCASPAR"; | ||
| repo = pname; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "v${version}"; | |
| tag = "v${version}"; |
|
|
||
| nativeBuildInputs = [ installShellFiles ]; | ||
|
|
||
| postInstall = '' |
There was a problem hiding this comment.
Suggested change
| postInstall = '' | |
| postInstall = lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) '' |
See #368256
Comment on lines
+20
to
+36
| mkdir $out/artifacts | ||
| pushd $out/artifacts | ||
|
|
||
| $out/bin/snow-plow gen-man | ||
| for shell in bash fish zsh; do | ||
| $out/bin/snow-plow gen-completion $shell | ||
| done | ||
| popd | ||
|
|
||
| installManPage $out/artifacts/*.1 | ||
| installShellCompletion \ | ||
| --cmd snow-plow \ | ||
| --bash $out/artifacts/snow-plow.bash \ | ||
| --fish $out/artifacts/snow-plow.fish \ | ||
| --zsh $out/artifacts/_snow-plow | ||
|
|
||
| rm -r $out/artifacts |
There was a problem hiding this comment.
Suggested change
| mkdir $out/artifacts | |
| pushd $out/artifacts | |
| $out/bin/snow-plow gen-man | |
| for shell in bash fish zsh; do | |
| $out/bin/snow-plow gen-completion $shell | |
| done | |
| popd | |
| installManPage $out/artifacts/*.1 | |
| installShellCompletion \ | |
| --cmd snow-plow \ | |
| --bash $out/artifacts/snow-plow.bash \ | |
| --fish $out/artifacts/snow-plow.fish \ | |
| --zsh $out/artifacts/_snow-plow | |
| rm -r $out/artifacts | |
| pushd $(mktemp -d) | |
| $out/bin/snow-plow gen-man | |
| for shell in bash fish zsh; do | |
| $out/bin/snow-plow gen-completion $shell | |
| done | |
| installManPage *.1 | |
| installShellCompletion \ | |
| --cmd snow-plow \ | |
| --bash snow-plow.bash \ | |
| --fish snow-plow.fish \ | |
| --zsh _snow-plow | |
| popd |
| ''; | ||
|
|
||
| cargoHash = "sha256-y8o3rn6+0Q/mDfi31sPYGynp4kMF5yFAWYp6vQgQEJc="; | ||
|
|
There was a problem hiding this comment.
Suggested change
| doInstallCheck = true; | |
| nativeInstallCheckInputs = [ versionCheckHook ]; | |
| versionCheckProgramArg = [ "--version" ]; | |
Just a suggestion: we can add versionCheckHook for a simple check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new package snow-plow, a utility package to update several flakes at once.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.