Skip to content

Conversation

Rishik-Y
Copy link
Member

@Rishik-Y Rishik-Y commented Dec 26, 2024

Note: This is a continued PR for #367897, I am just a newbie who doesn't know how to remove some of the commits, as per @drupol's instructions, so here is a new PR 😝

Package Information

  • Package name: Termius-beta
  • Latest released version: 9.9.0
  • Current version on the unstable channel: none
  • Current version on the stable/release channel: none

Notification for Termius Maintainer:
@Br1ght0ne @Th0rgal
Hi, I have utilized code from Termius and modified it for Termius-beta to work, and as far as testing goes Termius-beta works completely fine.
Since the code is very similar, i have kept both of you as Maintainers for Termius-beta as well.
If you don't want to be maintainer for this code, its completely fine just do notify me 🤗

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 26, 2024
@Rishik-Y Rishik-Y mentioned this pull request Dec 26, 2024
13 tasks
@Rishik-Y Rishik-Y marked this pull request as draft December 26, 2024 05:35
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 26, 2024
@Rishik-Y Rishik-Y marked this pull request as ready for review December 26, 2024 05:41
@Rishik-Y
Copy link
Member Author

Hi @drupol, could you review the content of the nix file now?

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 26, 2024
@ofborg ofborg bot requested review from Th0rgal and Br1ght0ne December 26, 2024 08:05
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 26, 2024
@github-actions github-actions bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 29, 2024
@Rishik-Y Rishik-Y force-pushed the Rishik-Y-patch-1 branch 4 times, most recently from cb157aa to e5179f6 Compare December 29, 2024 07:18
@Rishik-Y
Copy link
Member Author

Hi @drupol,
Now i know how to squash commits
and fixed the issues
So here is the updated one

@ofborg ofborg bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 29, 2024
@github-actions github-actions bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Jan 19, 2025
@Moraxyc Moraxyc mentioned this pull request Feb 18, 2025
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants