-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Termius-beta: init at 9.9.0 #368256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rishik-Y
wants to merge
3
commits into
NixOS:master
Choose a base branch
from
Rishik-Y:Rishik-Y-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Termius-beta: init at 9.9.0 #368256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Hi @drupol, could you review the content of the nix file now? |
265778d
to
e5179f6
Compare
cb157aa
to
e5179f6
Compare
e5179f6
to
f1a8675
Compare
Hi @drupol, |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: merge conflict
This PR has merge conflicts with the target branch
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin.
10.rebuild-linux: 1-10
This PR causes between 1 and 10 packages to rebuild on Linux.
11.by: package-maintainer
This PR was created by a maintainer of all the package it changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a continued PR for #367897, I am just a newbie who doesn't know how to remove some of the commits, as per @drupol's instructions, so here is a new PR 😝
Package Information
Notification for Termius Maintainer:
@Br1ght0ne @Th0rgal
Hi, I have utilized code from Termius and modified it for Termius-beta to work, and as far as testing goes Termius-beta works completely fine.
Since the code is very similar, i have kept both of you as Maintainers for Termius-beta as well.
If you don't want to be maintainer for this code, its completely fine just do notify me 🤗
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.