Termius-beta: init at 9.9.0 #367897
Closed
Termius-beta: init at 9.9.0 #367897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the error, |
drupol
requested changes
Dec 25, 2024
There was a problem hiding this comment.
Hello !
Thanks for your contribution!
A couple of tips:
- This PR must contains 2 commits only:
- A commit to add you in the maintainer list
- A commit to add Termius-beta
- No merge commits
- You must pass the new nix files through
nixfmt-rfc-style
Once this is done, I'll review the content of the nix file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package Information
Notification for Termius Maintainer:
@Br1ght0ne @Th0rgal
Hi, I have utilized code from Termius and modified it for Termius-beta to work, and as far as testing goes Termius-beta works completely fine.
Since the code is very similar, i have kept both of you as Maintainers for Termius-beta as well.
If you don't want to be maintainer for this code, its completely fine just do notify me 🤗
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.