gpu-screen-recorder{,-gtk}: add passthru.updateScript, update #367552

js6pak · 2024-12-23T04:30:26Z

Things done

Add a 👍 reaction to pull requests you find important.

keenanweaver

Don't know how to test it locally, but it looks great.

keenanweaver · 2024-12-31T02:17:07Z

5.0.0 is now out: https://git.dec05eba.com/gpu-screen-recorder/

pkgs/applications/video/gpu-screen-recorder/default.nix

pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-gtk.nix

js6pak · 2024-12-31T02:43:37Z

There is also gpu-screen-recorder-ui now, which is interesting

keenanweaver · 2024-12-31T02:47:40Z

There is also gpu-screen-recorder-ui now, which is interesting

I was just opening a packaging request for this. Looks like someone already did some preliminary work: https://github.com/Nowaaru/nix-diary/tree/6230e94b178924e7455a1dc0d318f50e10c8aec6/modules/gpu-screen-recorder/packages.

The module would probably need to be updated as well.

keenanweaver

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367552

`x86_64-linux`

✅ 2 packages built:

gpu-screen-recorder
gpu-screen-recorder-gtk

donovanglover · 2025-02-08T16:38:48Z

pkgs/by-name/gp/gpu-screen-recorder-gtk/package.nix

 }:

-stdenv.mkDerivation (finalAttrs: {
+stdenv.mkDerivation rec {


Suggested change

stdenv.mkDerivation rec {

stdenv.mkDerivation (finalAttrs: {

https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293

Using finalAttrs instead of rec for version here would lead to #310373. I don't think there is a consensus on the best solution, but rec works fine here.

donovanglover · 2025-02-08T16:44:56Z

pkgs/by-name/gp/gpu-screen-recorder-gtk/package.nix

-    url = "https://dec05eba.com/snapshot/gpu-screen-recorder-gtk.git.${finalAttrs.version}.tar.gz";
-    hash = "sha256-uXbiuA1XPWZVwQGLh47rKzCZSEUEPWqYALqMuCGA7do=";
+  src = fetchgit {
+    url = "https://repo.dec05eba.com/${pname}";


Suggested change

url = "https://repo.dec05eba.com/${pname}";

url = "https://repo.dec05eba.com/gpu-screen-recorder-gtk";

#277994

rec being constant doesn't introduce any overriding traps here, so whether you use ${pname} or a literal value is a subjective choice. Imo this is nicer because it can be shared across all gpu-screen-recorder-* packages.

pkgs/by-name/gp/gpu-screen-recorder-gtk/package.nix

pkgs/by-name/gp/gpu-screen-recorder/package.nix

pkgs/by-name/gp/gpu-screen-recorder-gtk/package.nix

pkgs/by-name/gp/gpu-screen-recorder/package.nix

js6pak · 2025-03-03T19:13:21Z

So... how do I get this merged?

keenanweaver · 2025-03-03T19:32:43Z

So... how do I get this merged?

Basically have to wait for a committer to review and merge. You could try posting that the PR is ready for review in this thread which I've seen speed up PR reviews. Afraid there's not much else aside from pinging committers which I think is considered taboo.

keenanweaver

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367552

`x86_64-linux`

✅ 2 packages built:

gpu-screen-recorder
gpu-screen-recorder-gtk

nixos-discourse · 2025-03-03T20:08:38Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5256

Gliczy · 2025-05-11T10:07:49Z

I'm not sure why ofborg-eval failed, but this still compiles and run fine.

keenanweaver · 2025-05-11T10:52:35Z

The GTK app is no longer being developed.

No need to drop from nixpkgs yet, just something to note.

js6pak · 2025-05-11T16:20:52Z

I have added cap_sys_nice back (6480b97) since 5.5.2 is supposed to fix the issue it caused for portal capture, but it still doesn't work for me.

❯ ./result/bin/gpu-screen-recorder --list-capture-options /dev/dri/card0 amd
DP-1|3840x2160
DP-2|2560x1440
region
portal

❯ /run/wrappers/bin/gpu-screen-recorder --list-capture-options /dev/dri/card0 amd
DP-1|3840x2160
DP-2|2560x1440
region
gsr error: gsr_dbus_call_screencast_method: failed with error: Portal operation not allowed: Unable to open /proc/440809/root
gsr error: gsr_dbus_screencast_create_session: failed to setup ScreenCast session. Make sure you have a desktop portal running with support for the ScreenCast interface and that the desktop portal matches the Wayland compositor you are running.
gsr error: gsr_dbus_client_screencast_create_session: server return error: Failed to handle request (-1)

I guess that's caused by our security wrappers making the capabilities ambient?

nixpkgs/nixos/modules/security/wrappers/wrapper.c

Line 199 in c542760

if (make_caps_ambient("/proc/self/exe") != 0) {

dec05eba · 2025-05-11T16:28:20Z

Hmm seems like it. The fix in 5.5.2 was to move that dbus code to another process (a child process) that runs the included program gsr-dbus-server. Normally a child process doesn't inherit the capability of the parent process since it has cap_sys_nice+ep as opposed to cap_sys_nice+eip.

js6pak · 2025-05-11T16:32:36Z

Adding a prctl(PR_CAP_AMBIENT, PR_CAP_AMBIENT_CLEAR_ALL, 0, 0, 0); before the execvp here https://git.dec05eba.com/gpu-screen-recorder/tree/dbus/client/dbus_client.c?h=5.5.2&id=0ae5b83e476ed6345c536a438ce5d61e60a11f45#n70, seems to work, but definitely feels hacky.

dec05eba · 2025-05-11T16:33:34Z

I'll add that then. As long as it works!

js6pak · 2025-05-11T16:37:39Z

@dec05eba Also, how would I test that cap_sys_nice actually works?

dec05eba · 2025-05-11T16:42:55Z

@js6pak I added the ambient fix you mentioned and released it as part of 5.5.3. With that version it also mentions if cap_sys_nice is not working. If it's not working then it outputs this when you run gpu-screen-recorder --info for example:

amdgpu: amdgpu_cs_ctx_create2 failed. (-13)
gsr warning: cap_sys_nice capability is missing on the gpu-screen-recorder binary, performance might be affected. If you are using the flatpak version of gpu-screen-recorder then the only fix is to use a non-flatpak version of gpu-screen-recorder

This reverts commit 7b69d08, because gpu-screen-recorder 5.5.2 fixes the original issue.

js6pak · 2025-05-11T17:06:00Z

Both cap_sys_nice and portal capture are working now. Thanks @dec05eba!

keenanweaver

Still functioning great. I'm hoping this can finally be merged along with #369574

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367552

`x86_64-linux`

⏩ 2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

✅ 2 packages built:

gpu-screen-recorder
gpu-screen-recorder-gtk

pbsbot · 2025-06-06T00:23:35Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367552
Commit: 110d7b29b30208a6aaa4e95b8c878e3d6e4c0709

`x86_64-linux`

⏩ 2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

✅ 2 packages built:

gpu-screen-recorder
gpu-screen-recorder-gtk

github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 23, 2024

keenanweaver approved these changes Dec 23, 2024

View reviewed changes

keenanweaver mentioned this pull request Dec 23, 2024

gpu-screen-recorder{-,gtk}: 4.2.3 -> 4.3.3 #359178

Closed

13 tasks

wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 23, 2024

ofborg bot requested a review from babbaj December 23, 2024 17:44

keenanweaver suggested changes Dec 31, 2024

View reviewed changes

js6pak force-pushed the gpu-screen-recorder/update-script branch from 3981d06 to f48ec9d Compare December 31, 2024 02:51

js6pak mentioned this pull request Dec 31, 2024

gpu-screen-recorder-ui: init at 1.7.5 #369574

Open

13 tasks

wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 31, 2024

keenanweaver approved these changes Dec 31, 2024

View reviewed changes

keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 31, 2024

js6pak force-pushed the gpu-screen-recorder/update-script branch from f48ec9d to 092f692 Compare February 3, 2025 00:09

wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 4, 2025

keenanweaver approved these changes Feb 7, 2025

View reviewed changes

keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 7, 2025

donovanglover reviewed Feb 8, 2025

View reviewed changes

js6pak force-pushed the gpu-screen-recorder/update-script branch from 092f692 to 8b1deb5 Compare February 8, 2025 20:34

wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 9, 2025

keenanweaver suggested changes Feb 27, 2025

View reviewed changes

js6pak force-pushed the gpu-screen-recorder/update-script branch from 8b1deb5 to 4236157 Compare March 3, 2025 19:11

js6pak requested a review from keenanweaver March 3, 2025 19:12

keenanweaver approved these changes Mar 3, 2025

View reviewed changes

keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 3, 2025

wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 5, 2025

js6pak force-pushed the gpu-screen-recorder/update-script branch from eee6cc0 to 281bffb Compare May 8, 2025 15:18

isabelroses removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 8, 2025

dec05eba mentioned this pull request May 11, 2025

gpu-screen-recorder: 5.2.0 -> 5.4.0 #402864

Closed

13 tasks

rezarajan mentioned this pull request May 11, 2025

gpu-screen-recorder: 5.5.1 -> 5.5.2 #406168

Closed

13 tasks

js6pak force-pushed the gpu-screen-recorder/update-script branch from 281bffb to c34d9ef Compare May 11, 2025 15:32

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 11, 2025

js6pak added 7 commits May 11, 2025 19:01

gpu-screen-recorder{,-gtk}: move to pkgs/by-name

e39a299

gpu-screen-recorder{,-gtk}: add passthru.updateScript

2f3a205

gpu-screen-recorder{,-gtk}: use fetchgit instead of fetchurl

ee02281

gpu-screen-recorder{,-gtk}: add myself as maintainer

9bfb3e7

gpu-screen-recorder: 5.2.0 -> 5.5.3

6fe3a61

nixos/gpu-screen-recorder: add cap_sys_nice back

f18cf01

This reverts commit 7b69d08, because gpu-screen-recorder 5.5.2 fixes the original issue.

gpu-screen-recorder-gtk: 5.1.6 -> 5.7.0

110d7b2

js6pak force-pushed the gpu-screen-recorder/update-script branch from c34d9ef to 110d7b2 Compare May 11, 2025 17:04

js6pak requested a review from keenanweaver May 11, 2025 18:44

keenanweaver approved these changes May 12, 2025

View reviewed changes

wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 14, 2025

pbsds merged commit 9477c8f into NixOS:master Jun 6, 2025
30 checks passed

	url = "https://repo.dec05eba.com/${pname}";
	url = "https://repo.dec05eba.com/gpu-screen-recorder-gtk";

Uh oh!

gpu-screen-recorder{,-gtk}: add passthru.updateScript, update #367552

gpu-screen-recorder{,-gtk}: add passthru.updateScript, update #367552

Uh oh!

Conversation

js6pak commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

keenanweaver left a comment

Choose a reason for hiding this comment

Uh oh!

keenanweaver commented Dec 31, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

js6pak commented Dec 31, 2024

Uh oh!

keenanweaver commented Dec 31, 2024

Uh oh!

keenanweaver left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

Uh oh!

donovanglover Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

js6pak Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

donovanglover Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

js6pak Feb 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

js6pak commented Mar 3, 2025

Uh oh!

keenanweaver commented Mar 3, 2025

Uh oh!

keenanweaver left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

Uh oh!

nixos-discourse commented Mar 3, 2025

Uh oh!

Gliczy commented May 11, 2025

Uh oh!

keenanweaver commented May 11, 2025

Uh oh!

js6pak commented May 11, 2025

Uh oh!

dec05eba commented May 11, 2025

Uh oh!

js6pak commented May 11, 2025

Uh oh!

dec05eba commented May 11, 2025

Uh oh!

js6pak commented May 11, 2025

Uh oh!

dec05eba commented May 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

js6pak commented May 11, 2025

Uh oh!

keenanweaver left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

Uh oh!

js6pak commented Dec 23, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

dec05eba commented May 11, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`