Skip to content

foxglove-studio: init at 2.18.1 #366007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

foxglove-studio: init at 2.18.1 #366007

wants to merge 2 commits into from

Conversation

lennart-rth
Copy link

Adds the foxglove-studio application.
Its a platform enabling robotics teams to record, process, visualize, and collaborate on multimodal robot data for accelerated development and intelligent iteration.
It is proprietary and only available as a binary so this is packaged and patched using patchelf.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 17, 2024
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Dec 17, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 17, 2024
pluiedev
pluiedev suggested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Nixpkgs ❤️ Here are some suggestions

@github-actions github-actions bot added 6.topic: vscode A free and versatile code editor that supports almost every major programming language. and removed 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Dec 17, 2024
@github-actions github-actions bot removed the 6.topic: vscode A free and versatile code editor that supports almost every major programming language. label Dec 17, 2024
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 17, 2024
@lennart-rth lennart-rth force-pushed the master branch 2 times, most recently from 1d79c3e to 1ad8401 Compare December 18, 2024 01:10
pluiedev
pluiedev suggested changes Dec 18, 2024
View reviewed changes
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 18, 2024
@lennart-rth
Copy link
Author

Can these checks be manually re-run? Both are https problems that would probably pass on a second run

@pluiedev
Copy link
Member

I don't think I can do it (not a committer), but a dumb way is to simply amend your latest commit and push

@github-actions github-actions bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 22, 2024
@lennart-rth
Copy link
Author

Ok thanks for all the tips :)

@ofborg ofborg bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 23, 2024
FliegendeWurst
FliegendeWurst reviewed Jan 26, 2025
View reviewed changes
FliegendeWurst
FliegendeWurst reviewed Jan 31, 2025
View reviewed changes
FliegendeWurst
FliegendeWurst reviewed Jan 31, 2025
View reviewed changes
FliegendeWurst
FliegendeWurst reviewed Feb 8, 2025
View reviewed changes
@Sascha8a Sascha8a mentioned this pull request Jun 18, 2025
Open
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

+1 more reviewer

@pluiedev pluiedev pluiedev requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lennart-rth @pluiedev @FliegendeWurst @NixOSInfra