rage: add mount feature #364725
Open
rage: add mount feature #364725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5db93a6 to
7beec5a
Compare
7beec5a to
9411f51
Compare
Eveeifyeve
suggested changes
Aug 15, 2025
| (if stdenv.hostPlatform.isDarwin then fuse else fuse3) | ||
| ] | ||
| ++ lib.optionals stdenv.hostPlatform.isDarwin [ | ||
| darwin.apple_sdk.frameworks.Foundation |
There was a problem hiding this comment.
Suggested change
| darwin.apple_sdk.frameworks.Foundation | |
| apple-sdk |
Please use the apple sdk.
| @@ -20,13 +23,19 @@ rustPlatform.buildRustPackage rec { | |||
|
|
|||
| cargoHash = "sha256-Nhm6xn7Upc9m+sTU9Pw3NGdpvwHvb4JGN6CQuMykILo="; | |||
|
|
|||
| buildFeatures = lib.lists.optional stdenv.hostPlatform.isUnix "mount"; | |||
There was a problem hiding this comment.
I would say leave it up to the user to override the feature unless it is enabled by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mount feature by default. This add new binary:
rage-mount(https://github.com/str4d/rage/tree/main#feature-flags)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.