-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
nixos/linkwarden: init module, linkwarden: init at 2.11.5 #347353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
53fb536
to
73ed656
Compare
c68a697
to
75c84ce
Compare
3df49a6
to
aa7a032
Compare
I've updated this PR now to the new version of linkwarden which does not need patching any more (all my PRs have been merged) |
Just updated my own linkwarden instance and everything works as expected |
aa7a032
to
b33907d
Compare
b33907d
to
2e32bbe
Compare
cc46f2a
to
f0809e9
Compare
Updated to version |
Tested the module, it seams to work OK (thanks for the amazing work ❤️ )
One quick fix would be to enable temporarily the registration, and disable it later on. EDIT: |
Yes, something like that should be done upstream, not in this module. One other workaround is to just use OIDC instead of the builtin user management (that's what I use) |
I just retested the module on my machine. In my setup, secrets are stored in sops-nix, and I use Authelia for OIDC. The module seems to be working perfectly!
|
f0809e9
to
78f7a99
Compare
@drupol I have addressed all review comments |
78f7a99
to
e95e49c
Compare
Something seems to be wrong with ofborg, I can build and run the PR just fine.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing, can you add a nixos release note entry? Then we can merge this.
e95e49c
to
184617b
Compare
I added one now. I was not sure as the 25.11 release notes file did not have the "New modules" sections so I thought the release notes might no longer show new modules |
184617b
to
38fdb58
Compare
Ok, that just fails. Where am I supposed to add to the release notes? The "other notable changes section"? |
38fdb58
to
217e8a3
Compare
oh weird, why are those (partially) duplicated? |
I'm not sure why but I guess the final page is generated from partials. Thanks for the work, I'm running the module for a few months without any issue 👍 |
EnvironmentFile = cfg.environmentFile; | ||
StateDirectory = "linkwarden"; | ||
CacheDirectory = "linkwarden"; | ||
User = cfg.user; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it mandatory to create a specific user? Can't we use dynamicUser instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linkwarden saves a bunch of files to disk (ie the saved web pages). If you want to use a separate service to back up those files, wouldn't DynamicUser mess up file permissions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmh to be tested I would say? I don't think you should create a specific user for the backup, if you're able to run the service with dynamicUser, do it and we'll deal with potential backup later. Using dynamicUser should simplify the config too.
Linkwarden is a self-hosted bookmarks manager: https://linkwarden.app/
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.