-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
freecad: work around https://github.com/FreeCAD/FreeCAD/issues/10514 #346740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freecad: work around https://github.com/FreeCAD/FreeCAD/issues/10514 #346740
Conversation
bfcdddd
to
16ad0d1
Compare
* Fixes NixOS#284880 * Also discussed on https://discourse.nixos.org/t/freecad-failed-to-compute-left-right-minimum-bearings-for-cursor-pcf/35266 Symptom is that failure to load a fixed font is followed by a flood of 'Failed to compute left/right minimum bearings for "cursor.pcf"' messages that can freeze up the machine. Isssue FreeCAD issue tracker FreeCAD/FreeCAD#10514 Is not yet fixed, but with a working solution, which has not made it into the repo yet: FreeCAD/FreeCAD#10514 (comment) The hotfix from that comment is added here slightly adated as freecad-font-10514.patch
16ad0d1
to
dd53928
Compare
Looks good ? Would be good to get it merged to make freecad usable in Nix. |
Ready to approve and merge ? |
Can you review this change @AndersonTorres ? This would be really good to have to have a usable freecad that does not lock up and use 100% resources. |
widening the audience to @kirillrdy who merged the 0.21 -> 1.0rc2 #343592 PR |
@srounce If you want to get review requests for packages you maintain you need to join the https://github.com/orgs/NixOS/teams/nixpkgs-maintainers team |
Yeah, but I ( @hzeller ) am not a maintainer of this package, just someone who had a fix. |
oh, I see, you mean that @srounce gets the notifications for this PR. |
i'm still getting this on current deftdawg's workaround mentioned here (and launching FreeCAD from the same shell i did that in) indeed got rid of the spam and made FreeCAD usable |
Symptom is that failure to load a fixed font is followed by a flood of
'Failed to compute left/right minimum bearings for "cursor.pcf"'
messages that can freeze up the machine.
Isssue FreeCAD issue tracker FreeCAD/FreeCAD#10514
Is not yet fixed, but with a working solution, which has not made it into the repo yet: FreeCAD/FreeCAD#10514 (comment) The hotfix from that comment is added here slightly edited as freecad-font-10514.patch
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.