Skip to content

Conversation

hzeller
Copy link
Contributor

@hzeller hzeller commented Oct 5, 2024

Symptom is that failure to load a fixed font is followed by a flood of
'Failed to compute left/right minimum bearings for "cursor.pcf"'
messages that can freeze up the machine.

Isssue FreeCAD issue tracker FreeCAD/FreeCAD#10514

Is not yet fixed, but with a working solution, which has not made it into the repo yet: FreeCAD/FreeCAD#10514 (comment) The hotfix from that comment is added here slightly edited as freecad-font-10514.patch

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from AndersonTorres and gebner October 5, 2024 22:16
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 5, 2024
@hzeller hzeller force-pushed the feature-20241005-work-around-10514 branch from bfcdddd to 16ad0d1 Compare October 6, 2024 00:50
  * Fixes NixOS#284880
  * Also discussed on https://discourse.nixos.org/t/freecad-failed-to-compute-left-right-minimum-bearings-for-cursor-pcf/35266

Symptom is that failure to load a fixed font is followed by a flood of
 'Failed to compute left/right minimum bearings for "cursor.pcf"'
messages that can freeze up the machine.

Isssue FreeCAD issue tracker FreeCAD/FreeCAD#10514

Is not yet fixed, but with a working solution, which has not made it into the repo yet:
FreeCAD/FreeCAD#10514 (comment)
The hotfix from that comment is added here slightly adated as freecad-font-10514.patch
@hzeller hzeller force-pushed the feature-20241005-work-around-10514 branch from 16ad0d1 to dd53928 Compare October 6, 2024 00:52
@ofborg ofborg bot requested a review from AndersonTorres October 6, 2024 01:27
@hzeller
Copy link
Contributor Author

hzeller commented Oct 8, 2024

Looks good ? Would be good to get it merged to make freecad usable in Nix.

@hzeller
Copy link
Contributor Author

hzeller commented Oct 12, 2024

Ready to approve and merge ?

@hzeller
Copy link
Contributor Author

hzeller commented Oct 16, 2024

Can you review this change @AndersonTorres ?

This would be really good to have to have a usable freecad that does not lock up and use 100% resources.

@hzeller hzeller requested a review from kirillrdy October 19, 2024 15:56
@hzeller
Copy link
Contributor Author

hzeller commented Oct 19, 2024

widening the audience to @kirillrdy who merged the 0.21 -> 1.0rc2 #343592 PR

@Artturin Artturin merged commit 63da90a into NixOS:master Oct 19, 2024
25 checks passed
@Artturin
Copy link
Member

@srounce If you want to get review requests for packages you maintain you need to join the https://github.com/orgs/NixOS/teams/nixpkgs-maintainers team

@hzeller
Copy link
Contributor Author

hzeller commented Oct 19, 2024

Yeah, but I ( @hzeller ) am not a maintainer of this package, just someone who had a fix.

@hzeller
Copy link
Contributor Author

hzeller commented Oct 19, 2024

oh, I see, you mean that @srounce gets the notifications for this PR.

@evils
Copy link
Member

evils commented Nov 9, 2024

i'm still getting this on current nixos-unstable with freecad-wayland (on sway) which should include this workaround

deftdawg's workaround mentioned here (and launching FreeCAD from the same shell i did that in) indeed got rid of the spam and made FreeCAD usable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FreeCAD: Failed to compute left/right minimum bearings for "cursor.pcf"
4 participants