xen: support aarch64-linux #345217
Draft
xen: support aarch64-linux #345217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SigmaSquadron
approved these changes
Sep 29, 2024
| @@ -717,8 +721,9 @@ stdenv.mkDerivation (finalAttrs: { | |||
|
|
|||
| mainProgram = "xl"; | |||
|
|
|||
| # Evaluates to x86_64-linux. | |||
| platforms = lib.lists.intersectLists lib.platforms.linux lib.platforms.x86_64; | |||
| # Evaluates to [x86_64-linux aarch64-linux]. | |||
There was a problem hiding this comment.
Suggested change
| # Evaluates to [x86_64-linux aarch64-linux]. | |
| # Evaluates to [ "x86_64-linux" "aarch64-linux" ]. |
nixfmt-rfc-style won't pick up the comment.
|
I do wonder if we can begin building |
emilazy
requested changes
Oct 7, 2024
| @@ -381,7 +384,8 @@ stdenv.mkDerivation (finalAttrs: { | |||
| ] | |||
| ++ lib.lists.optional withInternalOVMF nasm | |||
| ++ lib.lists.optional withFlask checkpolicy | |||
| ++ lib.lists.optional (lib.strings.versionOlder version "4.19") systemdMinimal; | |||
| ++ lib.lists.optional (lib.strings.versionOlder version "4.19") systemdMinimal | |||
| ++ lib.lists.optional stdenv.targetPlatform.isAarch64 dtc; | |||
There was a problem hiding this comment.
targetPlatform only applies to compilers. You want either stdenv.hostPlatform, which is the platform the resulting package will run on, or stdenv.buildPlatform, the platform the build is running on. Probably the former.
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.