Skip to content

ngs: init at 0.2.16 #345886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ngs: init at 0.2.16 #345886

wants to merge 1 commit into from

Conversation

momeemt
Copy link
Member

@momeemt momeemt commented Oct 2, 2024 •
edited by wolfgangwalther
Loading

ngs is the next generation shell.
I defined a derivation because #344215 and ngs-lang/ngs#661 requests this package.

https://github.com/ngs-lang/ngs

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 2, 2024
@romner-set
Copy link
Contributor

Doesn't seem to build properly, here's the relevant log:

build flags: -j12 SHELL=/nix/store/izpf49b74i15pcr9708s3xdwyqs4jxwl-bash-5.2p32/bin/bash
[ 14%] Generating syntax.include
[ 14%] Generating errno.include
[ 21%] Generating pcre_constants.include
[ 28%] Generating stdlib.ngs.h
/nix/store/izpf49b74i15pcr9708s3xdwyqs4jxwl-bash-5.2p32/bin/bash: line 1: /build/source/build-scripts/make-errno-include.sh: cannot execute: required file not found
make[2]: *** [CMakeFiles/ngs.dir/build.make:89: errno.include] Error 127
make[2]: *** Deleting file 'errno.include'
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:84: CMakeFiles/ngs.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 28%] Built target man
make: *** [Makefile:146: all] Error 2

@momeemt
Copy link
Member Author

momeemt commented Oct 15, 2024

Doesn't seem to build properly, here's the relevant log:

build flags: -j12 SHELL=/nix/store/izpf49b74i15pcr9708s3xdwyqs4jxwl-bash-5.2p32/bin/bash
[ 14%] Generating syntax.include
[ 14%] Generating errno.include
[ 21%] Generating pcre_constants.include
[ 28%] Generating stdlib.ngs.h
/nix/store/izpf49b74i15pcr9708s3xdwyqs4jxwl-bash-5.2p32/bin/bash: line 1: /build/source/build-scripts/make-errno-include.sh: cannot execute: required file not found
make[2]: *** [CMakeFiles/ngs.dir/build.make:89: errno.include] Error 127
make[2]: *** Deleting file 'errno.include'
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:84: CMakeFiles/ngs.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 28%] Built target man
make: *** [Makefile:146: all] Error 2

Thank you for checking to build. What the platform did build this package on?

@romner-set
Copy link
Contributor

x86_64-linux, sorry for not specifying. I just tested it on an aarch64-linux box and I'm getting the same error, so it seems to be an issue with linux builds instead of an issue with the architecture.

FliegendeWurst
FliegendeWurst requested changes Nov 1, 2024
View reviewed changes
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 10, 2025
@FliegendeWurst
Copy link
Member

FliegendeWurst commented Jan 10, 2025 •
edited
Loading

Build fails on Linux since it tries to download dependencies at build time. https://paste.fliegendewurst.eu/aC1y0c.log

(Since you enabled the Darwin sandbox you should see the same error?)

FliegendeWurst
FliegendeWurst reviewed Jan 10, 2025
View reviewed changes
pkgs/by-name/ng/ngs/package.nix

buildInputs = [
libffi
pandoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandoc also goes in native, unless ngs uses it at runtime.

@FliegendeWurst FliegendeWurst marked this pull request as draft March 10, 2025 15:34
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@momeemt @romner-set @FliegendeWurst @SigmaSquadron