Skip to content

beef: init at 0.43.5 #344933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

beef: init at 0.43.5 #344933

wants to merge 1 commit into from

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Sep 27, 2024

Description of changes

Closes #344087

(build time on my laptop was 11 minutes, and on my pc it was 5 minutes)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt force-pushed the beef branch 2 times, most recently from 33b2107 to b2906bc Compare September 27, 2024 21:18
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 27, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 29, 2024
@KiaraGrouwstra
Copy link
Contributor

Result of nixpkgs-review pr 344933 run on x86_64-linux 1

1 package built:
  • beef

@FliegendeWurst
Copy link
Member

Build fails on all platforms but x64 Linux, please update meta.platforms or meta.broken

@FliegendeWurst FliegendeWurst added the 2.status: needs-changes This PR needs changes by the author label Dec 15, 2024
@TomaSajt TomaSajt force-pushed the beef branch 2 times, most recently from ea2c3be to 37cc057 Compare December 28, 2024 19:33
@TomaSajt
Copy link
Contributor Author

Rebased and bumped to latest revision
(haven't disabled the other platforms: the OfBorg logs expired, so I'll wait for the new build to see what went wrong)

@TomaSajt
Copy link
Contributor Author

@ofborg build beef

@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 28, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 29, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 29, 2024
@Ch1keen
Copy link
Member

Ch1keen commented Feb 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 344933


x86_64-linux

✅ 1 package built:
  • beef

@FliegendeWurst
Copy link
Member

ofborg failed for all platforms != x64 Linux, this time around the logs are still available.

@TomaSajt TomaSajt force-pushed the beef branch 2 times, most recently from 7780fff to 972c9c6 Compare March 2, 2025 00:00
maintainers = with lib.maintainers; [ tomasajt ];
platforms = [
"x86_64-linux"
"x86_64-darwin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The x86_64-darwin is marked as broken in the line 88. But does it mean it supports the MacOS but only on x86_64 architecture?

@Ch1keen
Copy link
Member

Ch1keen commented Mar 2, 2025

I manually removed the broken = stdenv.hostPlatform.isDarwin; line and ran nix-build -I nixpkgs=. -A beef to check if the package could be built on my MacBook Pro (Intel), but it failed.

It might be worth simply removing x86_64-darwin from the supported platforms list.

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Mar 2, 2025

Upstream seems to only support building for aarch64 devices that are ios or android. This is why I only specified the x86_64 platforms.
The broken predicate just tells the user that even if the platform is supported by upstream, the program doesn't build on nixpkgs with that platform.

@TomaSajt TomaSajt changed the title beef: init at 0.43.4-unstable-2024-09-19 beef: init at 0.43.5 May 16, 2025
@FliegendeWurst FliegendeWurst removed the 2.status: needs-changes This PR needs changes by the author label May 16, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 25, 2025
@Masrkai
Copy link

Masrkai commented Aug 18, 2025

there is an info that is overlooked by @TomaSajt in his initial comment

beef here is beef the programming not beefproject known as beef-xss on many other distros the issue you mentioned in Closes #-344087 field is for beef-xss not this one please check what you are mentioning percisely

(i added the - to the number make the cluttering in the other issue less)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Beef
6 participants