python3Packages.parsedmarc: correct location of dependency management #337081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Background
parsedmarc
is both a Python module and CLI application which uses the module. Packaging of the Python module is currently broken by an unmet dependency. Packaging of the CLI application worked around this without correcting the broken module.Proposed change
Instead of managing the module’s dependencies in the application’s package, manage them in the module’s package. This will allow both the module and application to be usable.
Before:
pkgs.python3Packages.parsedmarc
module, broken by unmanaged dependenciespkgs.parsedmarc
applicationAfter:
pkgs.python3Packages.parsedmarc
modulepkgs.parsedmarc
applicationExample
Test functions
Before:
After:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.