llvmPackages.libunwind: add fake libgcc #330037
Conversation
b1d7c36 to
751864f
Compare
751864f to
e99b72c
Compare
e99b72c to
02551bf
Compare
|
rusti-cal builds, mesa which this is mainly needed for doesn't build until the deps are fixed. |
| @@ -26,4 +26,5 @@ if (( "${NIX_DEBUG:-0}" >= 1 )); then | |||
| printf " %q\n" "${extraAfter[@]}" >&2 | |||
| fi | |||
|
|
|||
| export NIX_LDFLAGS="@ldflags@ $NIX_LDFLAGS" | |||
There was a problem hiding this comment.
NIX_LDFLAGS_@suffixSalt@ is sometimes used for cross compiling, but it's not clear to me if we need it here.
There was a problem hiding this comment.
Yeah, I can't tell either. Maybe it'll be good to check how CC wrapper works and see if this could affect cross compiled LLVM Rust packages and if it does then add the suffix?
There was a problem hiding this comment.
@Ericson2314 probably knows. But not sure if his GitHub feed is too swamped as well.
There was a problem hiding this comment.
Is this a blocker or can it be resolved later?
There was a problem hiding this comment.
Not if nix-build -A tests.rust-hooks still succeeds.
4ad8701 to
38a1443
Compare
6cd78d3 to
195ebac
Compare
18b9e2f to
9972ad4
Compare
|
Not sure how that PR is related but I'll sort out that PR after this one is merged. I have some ideas to improve things. |
|
You mentioned it in #330037 (comment). |
|
Oh yeah, both PR's are needed so musl builds. |
9972ad4 to
4f84312
Compare
|
So this broke the cross-compile target for I've opened #418054 to try and fix that. |
Description of changes
Follow up to #320432
This is necessary to get some rust packages building with LLVM, notably mesa.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.