friction-graphics: init at 1.0.0-rc.2 #322957
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4271 |
| patchPhase = '' | ||
| sed -i 's|''${SKIA_SRC}/bin/gn)|${gn}/bin/gn)|' src/engine/CMakeLists.txt | ||
| sed -i 's|fontconfig|${fontconfig.lib}/lib/libfontconfig.so|' src/cmake/friction-common.cmake | ||
| grep -rl 'hb' | xargs sed -Ei 's/(["<])(hb.*\.h)/\1harfbuzz\/\2/' | ||
| ''; |
There was a problem hiding this comment.
| patchPhase = '' | |
| sed -i 's|''${SKIA_SRC}/bin/gn)|${gn}/bin/gn)|' src/engine/CMakeLists.txt | |
| sed -i 's|fontconfig|${fontconfig.lib}/lib/libfontconfig.so|' src/cmake/friction-common.cmake | |
| grep -rl 'hb' | xargs sed -Ei 's/(["<])(hb.*\.h)/\1harfbuzz\/\2/' | |
| ''; | |
| postPatch = '' | |
| sed -i 's|''${SKIA_SRC}/bin/gn)|${gn}/bin/gn)|' src/engine/CMakeLists.txt | |
| sed -i 's|fontconfig|${fontconfig.lib}/lib/libfontconfig.so|' src/cmake/friction-common.cmake | |
| grep -rl 'hb' | xargs sed -Ei 's/(["<])(hb.*\.h)/\1harfbuzz\/\2/' | |
| ''; | |
postPatch is usually placed right after src.
Also please use subtituteInPlace with --replace-fail if possbible so that we easily notice when things no longer match
There was a problem hiding this comment.
I couldn't work out if the last one was possible to change to substituteInPlace. It's replacing all #include <hb.h> and #include "hb.h" to #include <harfbuzz/hb.h>, since it seems this is where the harfbuzz that's how to get the header in harfbuzzFull. I'm not sure if it's too bad if this doesn't loudly fail though — it would mean that <hb.h> is no longer being referenced.
I updated the first two however, thanks for the advice 👍
| export VERBOSE=1 | ||
| cmake --build . --config Release |
There was a problem hiding this comment.
| export VERBOSE=1 | |
| cmake --build . --config Release | |
| cmake --build . --config Release |
Please use cmakeFlags to pass --config Release if necessary
There was a problem hiding this comment.
I'm not sure if that's possible, this is what I get when I try to do that:
It's a flag that's explicitly documented in their README so I assumed it was necessary
3035b87 to
b301531
Compare
6e798e9 to
b11b019
Compare
d65d7c2 to
5ecd3f6
Compare
|
Why is this never passing the formatting check? I am trying locally with the exact same commands and see no problems |
You need to rebase locally first. |
77456db to
1809c70
Compare
|
@FliegendeWurst thanks so much, it finally passes! I had thought that just using the rfc-style version would be enough, didn't realize that I could've had an outdated one locally |
| clangStdenv.mkDerivation rec { | ||
| pname = "friction.graphics"; | ||
| version = "0.9.6.1"; | ||
| src = fetchgit { |
There was a problem hiding this comment.
Please use fetchFromGitHub, with tag = "v${version}"
|
Hello, could you take a look at this again socksy and finish it? Thank you! |
|
Hi @socksy any chance you can follow through with this ? |
|
The last time I had look at it, 24.11 broke the build due to some clash with the forked (Worth noting perhaps that I had a working version of v0.9.6 in a flake at https://github.com/socksy/friction-graphics-flake) |
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.