libhwy: 1.0.7 -> 1.3.0 #320616
Draft
libhwy: 1.0.7 -> 1.3.0 #320616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4305 |
|
@ofborg build libhwy |
|
aarch64-linux fails to build |
NickCao
reviewed
Jul 27, 2024
There was a problem hiding this comment.
The riscv patch need an update:
diff --git a/pkgs/development/libraries/libhwy/default.nix b/pkgs/development/libraries/libhwy/default.nix
index c82d3738efe9..c5a777be8691 100644
--- a/pkgs/development/libraries/libhwy/default.nix
+++ b/pkgs/development/libraries/libhwy/default.nix
@@ -18,14 +18,13 @@ stdenv.mkDerivation rec {
hash = "sha256-yJQH5ZkpEdJ6lsTAt6yJSN3TQnVoxNpkbChENaxhcHo=";
};
- patches = lib.optional stdenv.hostPlatform.isRiscV
- # Adds CMake option HWY_CMAKE_RVV
- # https://github.com/google/highway/pull/1743
+ patches = [
(fetchpatch {
- name = "libhwy-add-rvv-optout.patch";
- url = "https://github.com/google/highway/commit/5d58d233fbcec0c6a39df8186a877329147324b3.patch";
- hash = "sha256-ileSNYddOt1F5rooRB0fXT20WkVlnG+gP5w7qJdBuww=";
- });
+ name = "disable-RVV-runtime-dispatch.patch";
+ url = "https://github.com/google/highway/commit/c95cc0237d2f7a0f5ca5dc3fb4b5961b2b1dcdfc.patch";
+ hash = "sha256-oQfyZrjZ9MGcSrFInbbj+0iOLjPng7tgTzli1QTITSg=";
+ })
+ ];
hardeningDisable = lib.optionals stdenv.hostPlatform.isAarch64 [
# aarch64-specific code gets:
Applied. Thank you! |
that still doesn't work... |
|
Yeah, I did not get to look at it. Let's convert to draft. |
|
7ea1332 landed in the interim. Maybe aarch64 works now? |
|
Sounds good. Let's try again. |
|
Ofborg says it still fails. Looks like a |
|
I know it is stale, but new version released: https://github.com/google/highway/releases/tag/1.3.0 |
Good catch! Updated to UPDATE: ofborg still fails:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.