Skip to content

wine64Packages.{stable,unstable,staging}: support GPTK on Darwin #319212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

reckenrode
Copy link
Contributor

Description of changes

All GPTK patches apply to Wine stable, unstable, and staging. D3DMetal 2.0b1 also works, but it won’t updated until a final release is available.

  • Port winemac.drv and ntdll changes from CrossOver; and
  • Revert Wine 9.10 commit that breaks GPTK.

Tested with https://gpuopen.com/learn/mlaa11-directx-11-sdk-sample/ and Bloodstained: Ritual of the Night.

Closes #236414.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

All GPTK patches apply to Wine stable, unstable, and staging. D3DMetal 2.0b1 also works, but it won’t updated until a final release is available.

- Port winemac.drv and ntdll changes from CrossOver; and
- Revert Wine 9.10 commit that breaks GPTK.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 12, 2024
@reckenrode reckenrode mentioned this pull request Jun 12, 2024
13 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 12, 2024
@reckenrode
Copy link
Contributor Author

@ofborg eval

@reckenrode
Copy link
Contributor Author

I updated the patch for Wine 9.12. They changed some of the internal APIs again.

@reckenrode reckenrode force-pushed the wine-d3dmetal branch 3 times, most recently from 718ebe9 to 98b3e5c Compare July 13, 2024 01:18
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@reckenrode reckenrode marked this pull request as draft February 18, 2025 17:03
@reckenrode
Copy link
Contributor Author

These patches are probably also out of date. I’ll wait to see what CrossOver does for Wine 10 (if anything). It’s possible that GPTK has no future on newer versions of Wine.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: game-porting-toolkit
2 participants