Skip to content

[Backport release-24.05] rustup: addressing a series of issues encountered while using Rust's self-contained ld.lld #319172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2024
Merged

[Backport release-24.05] rustup: addressing a series of issues encountered while using Rust's self-contained ld.lld #319172

merged 1 commit into from
Jun 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-24.05, triggered by a label in #314268.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@dianqk @github-actions
rustup: addressing a series of issues encountered while using Rust's
4c7a280 
self-contained `ld.lld`

(cherry picked from commit 198d712)
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Merged
13 tasks
@ofborg ofborg bot requested a review from Mic92 June 12, 2024 00:52
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 12, 2024
lschuermann
lschuermann approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me, and unbreaks rustup.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 15, 2024
@dianqk
Copy link
Contributor

dianqk commented Jun 19, 2024

Ping @Mic92 :3

@Aleksanaa Aleksanaa merged commit 5d6d5e0 into release-24.05 Jun 21, 2024
@Aleksanaa Aleksanaa deleted the backport-314268-to-release-24.05 branch June 21, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

1 more reviewer

@lschuermann lschuermann lschuermann approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dianqk @lschuermann @wegank @Aleksanaa