windows11-fonts: init at 10.0.26100.1742-3, windows10-fonts: init at 10.0.19045.2006-1 #315274

Sobte · 2024-05-28T07:08:55Z

Description of changes

I want to add windows fonts, just like vista-fonts and ttf-ms-win11-auto

Sorry, I accidentally rebase. I'm really sorry. I didn't mean to do that. #313500

Things done

Add a 👍 reaction to pull requests you find important.

Sobte · 2024-05-28T11:13:16Z

For @Cryolitia's reviews in #313500 (comment)

Tks, I have changed it to use outputs

SuperSandro2000 · 2024-05-28T12:06:58Z

pkgs/top-level/all-packages.nix

+  windows11-fonts = (callPackage ../data/fonts/windows-fonts { }).windows11;
+  windows10-fonts = (callPackage ../data/fonts/windows-fonts { }).windows10;


Suggested change

windows11-fonts = (callPackage ../data/fonts/windows-fonts { }).windows11;

windows10-fonts = (callPackage ../data/fonts/windows-fonts { }).windows10;

inherit (callPackage ../data/fonts/windows-fonts { }) windows10-fonts windows11-fonts;

Tks, I have completed the modification

SuperSandro2000 · 2024-05-28T12:08:55Z

pkgs/data/fonts/windows-fonts/default.nix

+              ''install -Dm644 ${source.${name}} -t $''
+              + name
+              + ''
+                /share/fonts/truetype
+                              ln -s $''
+              + name
+              + ''
+                /share/fonts/truetype/*.{ttf,ttc} $out/share/fonts/truetype
+                              install -Dm644 Windows/System32/Licenses/neutral/*/*/license.rtf -t $''
+              + name
+              + ''
+                /share/licenses
+              ''


Suggested change

''install -Dm644 ${source.${name}} -t $''

+ name

+ ''

/share/fonts/truetype

ln -s $''

+ name

+ ''

/share/fonts/truetype/*.{ttf,ttc} $out/share/fonts/truetype

install -Dm644 Windows/System32/Licenses/neutral/*/*/license.rtf -t $''

+ name

+ ''

/share/licenses

''

''

install -Dm644 ${source.${name}} -t ${name}/share/fonts/truetype

ln -s ${name}/share/fonts/truetype/*.{ttf,ttc} $out/share/fonts/truetype

install -Dm644 Windows/System32/Licenses/neutral/*/*/license.rtf -t ${name}/share/licenses

''

if this is wrong, then it just proves that the code before was not easy to understand

My source code is this:

''install -Dm644 ${source.${name}} -t $'' + name + ''/share/fonts/truetype ln -s $'' + name + ''/share/fonts/truetype/*.{ttf,ttc} $out/share/fonts/truetype install -Dm644 Windows/System32/Licenses/neutral/*/*/license.rtf -t $'' + name + '' /share/licenses ''

Because it needs to go through nixfmt-rfc-style, it becomes commit like this, I tried to change it, it should be much better if I declare a variable.

Current Code:

let outHome = "$" + name; in ('' install -Dm644 ${source.${name}} -t ${outHome}/share/fonts/truetype ln -s ${outHome}/share/fonts/truetype/*.{ttf,ttc} $out/share/fonts/truetype install -Dm644 Windows/System32/Licenses/neutral/*/*/license.rtf -t ${outHome}/share/licenses '')

SuperSandro2000 · 2024-05-28T12:09:20Z

pkgs/data/fonts/windows-fonts/default.nix

+
+      src = fetchurl { inherit url sha256; };
+
+      outputs = [ "out" ] ++ builtins.attrNames source;


I don't think we should do an output for every font.

It's for every language, not every font. Many latin world user may not care CJK fonts at all, and CJK fonts are really big.

For example, all default fonts are ~67.5M in total, 5 chinese fonts are ~84.5M in total.

SuperSandro2000 · 2024-05-28T12:12:00Z

pkgs/data/fonts/windows-fonts/default.nix

+    stdenvNoCC.mkDerivation {
+      inherit pname version desc;
+
+      src = fetchurl { inherit url sha256; };


Suggested change

src = fetchurl { inherit url sha256; };

src = fetchurl {

inherit url sha256;

meta.license = lib.licenses.unfree;

};

just to make sure that we don't ever cache this

Tks, I have added

SuperSandro2000 · 2024-05-28T12:12:14Z

pkgs/data/fonts/windows-fonts/default.nix

+    pname = "windows11-fonts";
+    version = "10.0.22631.2428-2";
+    url = "https://software-static.download.prss.microsoft.com/dbazure/888969d5-f34g-4e03-ac9d-1f9786c66749/22631.2428.231001-0608.23H2_NI_RELEASE_SVC_REFRESH_CLIENTENTERPRISEEVAL_OEMRET_x64FRE_en-us.iso";
+    sha256 = "sha256-yNvJa2HQTIsB+vbOB5T98zllx7NQ6qPrHmaXAZkClFw=";


Suggested change

sha256 = "sha256-yNvJa2HQTIsB+vbOB5T98zllx7NQ6qPrHmaXAZkClFw=";

hash = "sha256-yNvJa2HQTIsB+vbOB5T98zllx7NQ6qPrHmaXAZkClFw=";

SuperSandro2000 · 2024-05-28T12:12:22Z

pkgs/data/fonts/windows-fonts/default.nix

+      pname,
+      version,
+      url,
+      sha256,


Suggested change

sha256,

hash,

SuperSandro2000 · 2024-05-28T12:12:28Z

pkgs/data/fonts/windows-fonts/default.nix

+  windows11 = windows-fonts {
+    pname = "windows11-fonts";
+    version = "10.0.22631.2428-2";
+    url = "https://software-static.download.prss.microsoft.com/dbazure/888969d5-f34g-4e03-ac9d-1f9786c66749/22631.2428.231001-0608.23H2_NI_RELEASE_SVC_REFRESH_CLIENTENTERPRISEEVAL_OEMRET_x64FRE_en-us.iso";


What's the source of those?

This pkgs attempts to download fonts directly from Microsoft, by
retrieving selective parts of the Windows 10 Enterprise 90-day evaluation edition.

visit: https://www.microsoft.com/en-us/evalcenter/evaluate-windows-10-enterprise
iso file: https://www.microsoft.com/en-us/evalcenter/download-windows-10-enterprise

win11 is the same as above

visit: https://www.microsoft.com/en-us/evalcenter/evaluate-windows-11-enterprise
iso file: https://www.microsoft.com/en-us/evalcenter/download-windows-11-enterprise

SuperSandro2000 · 2024-05-28T12:12:41Z

pkgs/data/fonts/windows-fonts/windows10-fonts-languages.nix

@@ -0,0 +1,164 @@
+{
+  default = [


Would it make sense to dedupe them?

The two spec are slightly different, so I split them into two to facilitate subsequent spec updates.

Sobte · 2024-06-09T13:27:03Z

@SuperSandro2000 Please help review, thank you

dramforever

I was just made aware of this PR and I'm interested especially for the commonly used CJK fonts found here. I hope you don't mind the really late comments

dramforever · 2025-08-09T14:45:24Z

pkgs/data/fonts/windows-fonts/default.nix

+        + lib.strings.concatLines (
+          lib.lists.forEach (builtins.attrNames source) (
+            name:
+            let
+              outHome = "$" + name;
+            in
+            (''
+              install -Dm644 ${source.${name}} -t ${outHome}/share/fonts/truetype
+              ln -s ${outHome}/share/fonts/truetype/*.{ttf,ttc} $out/share/fonts/truetype
+              install -Dm644 Windows/System32/Licenses/neutral/*/*/license.rtf -t ${outHome}/share/licenses
+            '')
+          )
+        )


I recognize that it is probably subjective which one is more hedious than the other, but I don't like this code generation at all. I would replace this with __structuredAttrs = true;. You can use an associative array to get output paths in that case. See another (rather, the only other?) example in Nixpkgs:

nixpkgs/pkgs/tools/typesetting/tex/texlive/build-texlive-package.nix

Lines 288 to 294 in 240db6a

for outputName in ''${!outputs[@]} ; do

if [[ -n ''${outputDrvs[$outputName]} ]] ; then

ln -s "''${outputDrvs[$outputName]}" "''${outputs[$outputName]}"

else

touch "''${outputs[$outputName]}"

fi

done

However, the language list is still too complicated for bash associative arrays. I can see two options:

mapAttrs them into an attrset of space-separated file names, do word split in bash

invert the map, make them { "font.ttf" = "language"; ... } instead

dramforever · 2025-08-09T14:47:15Z

pkgs/data/fonts/windows-fonts/default.nix

+    version = "10.0.22631.2428-2";
+    url = "https://software-static.download.prss.microsoft.com/dbazure/888969d5-f34g-4e03-ac9d-1f9786c66749/22631.2428.231001-0608.23H2_NI_RELEASE_SVC_REFRESH_CLIENTENTERPRISEEVAL_OEMRET_x64FRE_en-us.iso";
+    hash = "sha256-yNvJa2HQTIsB+vbOB5T98zllx7NQ6qPrHmaXAZkClFw=";
+    desc = "Microsoft Windows 11 fonts";


Would this end up being Some TrueType fonts from Microsoft Windows 11 fonts with "fonts" twice? Is that intended?

Sobte · 2025-08-09T22:56:26Z

I was just made aware of this PR and I'm interested especially for the commonly used CJK fonts found here. I hope you don't mind the really late comments

Thank you so much for reviewing this PR! Your comments were very helpful, and I’ve made the suggested changes. Also, big thanks to @pluiedev for the assistance in completing this PR. I truly appreciate everyone’s time and support!

…10.0.19045.2006-1

Eveeifyeve · 2025-08-15T10:37:27Z

pkgs/by-name/wi/windows11-fonts/package.nix

+  meta = {
+    description = "Some TrueType fonts from ${os} (Arial, Bahnschrift, Calibri, ...)";
+    homepage = "https://learn.microsoft.com/typography/";
+    license = lib.licenses.unfree;


Question of licensing, would you have to agree to the windows license? if so should that be a thing that a user would have to configure for because it's a custom license aka a EULA?

Would say we need to do the same as the msvc sdk by adding the windows licence to config.nix like https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/windows/msvcSdk/default.nix if this is the case

github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 28, 2024

Sobte force-pushed the add_ms-win-font branch from f63fd60 to b591994 Compare May 28, 2024 11:05

ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels May 28, 2024

SuperSandro2000 reviewed May 28, 2024

View reviewed changes

Sobte force-pushed the add_ms-win-font branch from b591994 to b26864a Compare May 28, 2024 17:17

Sobte requested a review from SuperSandro2000 May 28, 2024 17:46

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025

nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 25, 2025

Cryolitia requested review from dramforever, Aleksanaa and linyinfeng August 9, 2025 09:39

nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 9, 2025

dramforever reviewed Aug 9, 2025

View reviewed changes

Sobte force-pushed the add_ms-win-font branch from b26864a to 0a7478f Compare August 9, 2025 23:02

Sobte marked this pull request as draft August 9, 2025 23:20

Sobte closed this Aug 9, 2025

Sobte force-pushed the add_ms-win-font branch from 0a7478f to 737e95f Compare August 9, 2025 23:29

maintainers: add Sobte

3b11a48

Sobte reopened this Aug 10, 2025

Sobte changed the title ~~windows11-fonts: init at 10.0.22631.2428-2, windows10-fonts: init at 10.0.19045.2006-1~~ windows11-fonts: init at 10.0.26100.1742-3, windows10-fonts: init at 10.0.19045.2006-1 Aug 10, 2025

nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 10, 2025

windows11-fonts: init at 10.0.26100.1742-3, windows10-fonts: init at …

7cd4e5a

…10.0.19045.2006-1

Sobte force-pushed the add_ms-win-font branch from b7c9e66 to 7cd4e5a Compare August 10, 2025 00:56

nixpkgs-ci bot removed the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Aug 10, 2025

Sobte marked this pull request as ready for review August 10, 2025 01:03

Eveeifyeve reviewed Aug 15, 2025

View reviewed changes

		windows11-fonts = (callPackage ../data/fonts/windows-fonts { }).windows11;
		windows10-fonts = (callPackage ../data/fonts/windows-fonts { }).windows10;

	windows11-fonts = (callPackage ../data/fonts/windows-fonts { }).windows11;
	windows10-fonts = (callPackage ../data/fonts/windows-fonts { }).windows10;
	inherit (callPackage ../data/fonts/windows-fonts { }) windows10-fonts windows11-fonts;


		src = fetchurl { inherit url sha256; };

		outputs = [ "out" ] ++ builtins.attrNames source;

	sha256 = "sha256-yNvJa2HQTIsB+vbOB5T98zllx7NQ6qPrHmaXAZkClFw=";
	hash = "sha256-yNvJa2HQTIsB+vbOB5T98zllx7NQ6qPrHmaXAZkClFw=";

	for outputName in ''${!outputs[@]} ; do
	if [[ -n ''${outputDrvs[$outputName]} ]] ; then
	ln -s "''${outputDrvs[$outputName]}" "''${outputs[$outputName]}"
	else
	touch "''${outputs[$outputName]}"
	fi
	done

Uh oh!

windows11-fonts: init at 10.0.26100.1742-3, windows10-fonts: init at 10.0.19045.2006-1 #315274

Are you sure you want to change the base?

windows11-fonts: init at 10.0.26100.1742-3, windows10-fonts: init at 10.0.19045.2006-1 #315274

Uh oh!

Conversation

Sobte commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

Sobte commented May 28, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sobte commented Jun 9, 2024

Uh oh!

dramforever left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sobte commented Aug 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sobte commented May 28, 2024 •

edited

Loading