simp: init at 3.5.3 #315825
Draft
simp: init at 3.5.3 #315825
+86
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f536edb to
2d48c0d
Compare
|
Seems to fail at runtime, on sway: |
There was a problem hiding this comment.
This should fix the runtime failures and also add AVIF and HEIF/HEIC support (I haven't tested the extra support yet, though.)
|
Hi! Thanks for your work. I also tried write derivation by myself and now it launch successfully. { lib
, rustPlatform
, fetchFromGitHub
, pkg-config
, libxkbcommon
, vulkan-loader
, stdenv
, darwin
, wayland
, makeDesktopItem
, copyDesktopItems
, cargo-about
, libGL
}:
rustPlatform.buildRustPackage rec {
pname = "simp";
version = "3.5.3";
src = fetchFromGitHub {
owner = "Kl4rry";
repo = "simp";
rev = "v${version}";
hash = "sha256-NALVHcU+NhCT5w+pn6WhP+cFGPuDhnPt+IDNHN/oqls=";
};
cargoHash = "sha256-Wp50ldXGy7MLQTnvZDx3LIr8jLBpkoCrh0/xPowIn54=";
nativeBuildInputs = [
pkg-config
cargo-about
copyDesktopItems
];
buildInputs = [
libxkbcommon
vulkan-loader
libGL
] ++ lib.optionals stdenv.isDarwin [
darwin.apple_sdk.frameworks.AppKit
darwin.apple_sdk.frameworks.CoreGraphics
darwin.apple_sdk.frameworks.CoreServices
darwin.apple_sdk.frameworks.Foundation
darwin.apple_sdk.frameworks.Metal
darwin.apple_sdk.frameworks.QuartzCore
] ++ lib.optionals stdenv.isLinux [
wayland
];
desktopItems = [
(makeDesktopItem {
name = "simp";
desktopName = "simp";
genericName= "Image Editor";
exec = "simp %U";
icon = "icon";
categories = [ "Graphics" ];
mimeTypes = [ "image/bmp" ];
})
];
preBuild = ''
mkdir -p $out/share/icons/hicolor/256x256/apps
cp $src/icon.png $out/share/icons/hicolor/256x256/apps/
sed -i '35,39c let git_hash=String::from("${version}");' build.rs
'';
postFixup = ''
patchelf $out/bin/${pname} \
--add-rpath ${lib.makeLibraryPath [ vulkan-loader libGL libxkbcommon wayland ]}
'';
meta = {
description = "Simp is a fast and simple GPU-accelerated image manipulation program";
homepage = "https://github.com/Kl4rry/simp";
license = lib.licenses.asl20;
maintainers = with lib.maintainers; [ ];
mainProgram = "simp";
};
} |
Co-authored-by: éclairevoyant <848000+eclairevoyant@users.noreply.github.com>
Aleksanaa
reviewed
Jun 16, 2024
|
|
||
| preBuild = '' | ||
| # replace variable from git cmd output | ||
| sed -i '35,39c let git_hash=String::from("${version}");' build.rs |
There was a problem hiding this comment.
This should be a patch. Using sed like this is extremely brittle
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
@RAVENz46 for testing.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.