Skip to content

cups3: init #313745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

cups3: init #313745

wants to merge 9 commits into from

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented May 22, 2024 •
edited by wolfgangwalther
Loading

Description of changes

Closes #306565
Closes #306566
Closes #306567

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 force-pushed the init-cups3-and-company branch from 8fd3d41 to 4ec40ac Compare May 22, 2024 18:04
@github-actions github-actions bot removed the 6.topic: printing Drivers, CUPS & Co. label May 22, 2024
AndersonTorres
AndersonTorres reviewed May 22, 2024
View reviewed changes
AndersonTorres
AndersonTorres suggested changes May 22, 2024
View reviewed changes
@Pandapip1 Pandapip1 added the 6.topic: printing Drivers, CUPS & Co. label May 22, 2024
@Pandapip1 Pandapip1 force-pushed the init-cups3-and-company branch from 4ec40ac to 805a060 Compare May 22, 2024 18:59
@github-actions github-actions bot removed the 6.topic: printing Drivers, CUPS & Co. label May 22, 2024
@Pandapip1 Pandapip1 added the 6.topic: printing Drivers, CUPS & Co. label May 22, 2024
@Pandapip1 Pandapip1 force-pushed the init-cups3-and-company branch from 805a060 to 2436f08 Compare May 22, 2024 19:00
@github-actions github-actions bot removed the 6.topic: printing Drivers, CUPS & Co. label May 22, 2024
AndersonTorres
AndersonTorres reviewed May 22, 2024
View reviewed changes
@Pandapip1 Pandapip1 force-pushed the init-cups3-and-company branch from e11c34e to e9fe6c5 Compare May 22, 2024 19:34
AndersonTorres
AndersonTorres reviewed May 22, 2024
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanups in the logic:

@Pandapip1 Pandapip1 force-pushed the init-cups3-and-company branch 5 times, most recently from b82e51a to 261360d Compare May 22, 2024 20:20
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 22, 2024
@Pandapip1 Pandapip1 force-pushed the init-cups3-and-company branch from 261360d to d19a250 Compare September 19, 2024 01:34
@Pandapip1 Pandapip1 force-pushed the init-cups3-and-company branch from d19a250 to f7e839e Compare September 19, 2024 04:19
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 26, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@AndersonTorres AndersonTorres AndersonTorres requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: cups-sharing Package request: cups-local Package request: libcups3
4 participants
@Pandapip1 @AndersonTorres @wolfgangwalther @wegank