The great python3.8 purge [1] (python == 3.5) #312552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabaff
requested changes
May 18, 2024
There was a problem hiding this comment.
I don't agree with removing pythonOlder only because it mention "3.5". It should stay as it in many cases it was added manually and helps to track in some ways the state of the module in Nixpkgs. Same as going for modules which still use sha256, mention format = "setuptools"; or have six in their inputs.
While checking a couple of modules it showed that the entry is simply outdated. During mass updates pythonOlder is not checked. Also, upstream is not always aware what releases their module actually support and it doesn't have to align us. If upstream says python_requires=">=3.5" then our pythonOlder entry does reflect hat.
fabaff
reviewed
May 18, 2024
1d9862d to
1c430ea
Compare
fabaff
requested changes
May 18, 2024
fabaff
reviewed
May 18, 2024
fabaff
reviewed
May 18, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of: #312288
This pr removes all the mention of
pythonOlder 3.5.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.