python312Packages.metaphlan: init at 4.1.0 #311463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 7 packages built:
|
Pandapip1
commented
May 13, 2024
| license = licenses.cc0; # These are raw data files not covered under copyright law | ||
| maintainers = with maintainers; [ pandapip1 ]; | ||
| platforms = platforms.all; | ||
| hydraPlatforms = []; # Exceeds Hydra's maximum build size |
There was a problem hiding this comment.
This particular package is a static database that metaphlan requires in order to function. It's quite large (~30GB built), and isn't terribly well compressed, so for as long as the builder has to keep srcs in storage, it'll effectively have double the storage use.
As this is insanely huge for a Nix package (enough so that hydra can't support it), I have disabled hydra builds for the database.
fabaff
reviewed
May 14, 2024
1be6733 to
baf8091
Compare
alyssais
reviewed
May 14, 2024
970eca5 to
a39b311
Compare
|
Re-requesting review: @fabaff |
|
@GrahamcOfBorg eval |
|
Bump |
f0114ff to
ad34079
Compare
|
I've made a couple modifications to save some disk space, format the packages more correctly, and build faster. |
ad34079 to
dcc2062
Compare
dcc2062 to
c9aef75
Compare
c9aef75 to
ac04262
Compare
|
Rebased, since it was getting a lil out of date. EDIT: Also just removed a |
ac04262 to
17dca0c
Compare
13 tasks
|
Result of 4 packages failed to build:
9 packages built:
|
17dca0c to
3df4d91
Compare
|
Result of 13 packages built:
|
3df4d91 to
9dcbc83
Compare
9dcbc83 to
e157c5d
Compare
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
e157c5d to
be33f63
Compare
gepbird
approved these changes
Dec 9, 2024
…ages.metaphlan}: transition to fetchurl { tag = ...; ...}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
NOTE: Fails due to a broken dependency on python >= 3.12 (#326199)51.55 GiB, due to a large database (metaphlan-db, size50.7 GiB) that is downloaded as part of the package.Closes #299219
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.