playit: init at 0.15.26 #294103
playit: init at 0.15.26 #294103
Conversation
|
This review has been done with warden, please report any issues! Packages built
✅ playit
|
| darwin.apple_sdk.frameworks.Security | ||
| ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
nix-unit thought it was neccses
There was a problem hiding this comment.
nix-init? You should test it yourself
There was a problem hiding this comment.
It worked, I do not have a darwin machine to test on.
There was a problem hiding this comment.
ofBorg will run the builds here. You can see if it fails
There was a problem hiding this comment.
Still, please either remove it or write reason in comment:
| doCheck = false; | |
| doCheck = false; # Whatever reason |
There was a problem hiding this comment.
Apparently, because doCheck required internet access?
|
I am not a fan of bumping PRs, but are there any updates on this? |
|
@ofborg build playit |
https://github.com/playit-cloud/playit-agent Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
|
|
||
| cargoHash = "sha256-HIwoPmxMvq3zlhzqSNKZVnWUxW9jE6c0lzztmSYpHzM="; | ||
|
|
||
| buildInputs = lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; |
There was a problem hiding this comment.
| buildInputs = lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; |
Such dependencies are no longer needed after darwin SDK rework.
| darwin.apple_sdk.frameworks.Security | ||
| ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Still, please either remove it or write reason in comment:
| doCheck = false; | |
| doCheck = false; # Whatever reason |
| meta = with lib; { | ||
| description = "Global proxy to run an online game server"; | ||
| homepage = "https://github.com/playit-cloud/playit-agent"; | ||
| license = licenses.bsd2; | ||
| maintainers = with maintainers; [ iogamaster ]; | ||
| mainProgram = "playit-cli"; |
There was a problem hiding this comment.
| meta = with lib; { | |
| description = "Global proxy to run an online game server"; | |
| homepage = "https://github.com/playit-cloud/playit-agent"; | |
| license = licenses.bsd2; | |
| maintainers = with maintainers; [ iogamaster ]; | |
| mainProgram = "playit-cli"; | |
| meta = { | |
| description = "Global proxy to run an online game server"; | |
| homepage = "https://github.com/playit-cloud/playit-agent"; | |
| license = lib.licenses.bsd2; | |
| maintainers = with lib.maintainers; [ iogamaster ]; | |
| mainProgram = "playit-cli"; |
|
I will wait for the build to finish, because I forgot to check last time :p Once that is done I will do all the updates and remove doCheck. |
|
It's fine now |
|
It would be nice if you could update the PR title |
|
Could we also alias postInstall = ''
ln -s $out/bin/playit-cli $out/bin/playit
''; |
|
Can we also define this as a service? Meanwhile, I'm doing this in my systemd.user.services.playit = {
Unit = {
description = "PlayIt";
};
Install = {
WantedBy = [ "multi-user.target" ];
};
Service = {
ExecStart = ''
${pkgs.lib.getExe playit} --stdout --secret_wait start
'';
};
}; |
|
is any work still being made on this pr? |
https://github.com/playit-cloud/playit-agent
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.